Part of #2509534: [Meta] document or refactor calls to drupal_render()

Problem/Motivation

AggregatorFeedBlock::build() uses deprecated drupal_render() but should return alterable render array. This causes breakage of caching.

Proposed resolution

Return a render array instead of rendering parts of block.

Remaining tasks

patch/commit

User interface changes

no

API changes

no

Beta phase evaluation

Reference: https://www.drupal.org/core/beta-changes
Issue category Bug because uses rendering in block build() code
Issue priority Normal because it's leftover code from 7.x
Disruption Non-disruptive for core/contributed and custom modules/themes
CommentFileSizeAuthor
aggregator-block.patch1.99 KBandypost

Comments

andypost’s picture

Category: Task » Bug report
wim leers’s picture

Status: Needs review » Reviewed & tested by the community
Issue tags: +Quickfix

Status: Reviewed & tested by the community » Needs work

The last submitted patch, aggregator-block.patch, failed testing.

Status: Needs work » Needs review

andypost queued aggregator-block.patch for re-testing.

dawehner’s picture

Status: Needs review » Reviewed & tested by the community

Looks perfect for me

alexpott’s picture

Status: Reviewed & tested by the community » Fixed

Let's let the render system render! Nice :)

Committed eb70a1c and pushed to 8.0.x. Thanks!

Thanks for adding the beta eval.

  • alexpott committed eb70a1c on 8.0.x
    Issue #2509600 by andypost: AggregatorFeedBlock should return render...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.