Problem/Motivation

ThemeManager class constructor use ThemeInitialization instead of ThemeInitializationInterface, adding faulty dependency to ThemeInitialization.

Proposed resolution

ThemeManager class constructor should be changed to use the ThemeInitializationInterface

User interface changes

none

API changes

none

CommentFileSizeAuthor
#1 faulty_dependency_to-2509434-1.patch1.6 KBwillzyx

Comments

willzyx’s picture

willzyx commented
StatusFileSize
new faulty_dependency_to-2509434-1.patch1.6 KB
dawehner’s picture

dawehner
Primary language German
commented
Status: Needs review » Reviewed & tested by the community
Issue tags: +Quickfix

+1

prettyblacc0504’s picture

prettyblacc0504 commented
prettyblacc0504’s picture

prettyblacc0504 commented
prettyblacc0504’s picture

prettyblacc0504 commented
prettyblacc0504’s picture

prettyblacc0504 commented
Assigned: Unassigned » prettyblacc0504
Category: Bug report » Feature request
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Needs review

prettyblacc0504 queued 1: faulty_dependency_to-2509434-1.patch for re-testing.

dawehner’s picture

dawehner
Primary language German
commented
Assigned: prettyblacc0504 » Unassigned
Category: Feature request » Bug report
Status: Needs review » Reviewed & tested by the community
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Yep we should be using interfaces here - this is an API broadening and not disruptive. Committed e6182f9 and pushed to 8.0.x. Thanks!

  • alexpott committed e6182f9 on 8.0.x 
    Issue #2509434 by willzyx: Faulty dependency to ThemeInitialization in...
willzyx’s picture

willzyx commented
Issue tags: +Faulty dependencies

tagging, so it is much easier to find these issues

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

triple5’s picture

triple5 commented

On using the beta12 release, I found that clicking on the "Install and set as default" link in /admin/appearance throws up an error: The Theme "... THEMENAME" was not found this happened with a version of mayo as well as with another of space theme.
However, while this error message appears, the theme is enabled / installed but not set default, upon clicking "set default" on the next page it works as expected.
There is no error logged. This behaviour is reproducible after deinstalling the theme.

willzyx’s picture

willzyx commented

@triple5 that issue should be fixed in the latest dev version. see #2498691: "Install and set as default" link on the Appearance page doesn't work