Problem/Motivation

commerce_reorder_preprocess_link can get called lots, to keep it fast as things scale, avoid doing early exploding.

Proposed resolution

Find a better way to check without exploding or explode later in the if statement.

Remaining tasks

User interface changes

API changes

Data model changes

Before

After

CommentFileSizeAuthor
#2 interdiff.txt544 bytesjoelpittet
#2 2507949-2.patch772 bytesjoelpittet
#1 2507949-1.patch725 bytesjoelpittet
#1 commerce_reorder_preprocess_link-before.png152.24 KBjoelpittet
#1 commerce_reorder_preprocess_link-after.png132.57 KBjoelpittet

Comments

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
Issue summary: View changes
Status: Active » Needs review
StatusFileSize
new commerce_reorder_preprocess_link-after.png132.57 KB
new commerce_reorder_preprocess_link-before.png152.24 KB
new 2507949-1.patch725 bytes

Attached some Before and After photos to the IS.

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
StatusFileSize
new 2507949-2.patch772 bytes
new interdiff.txt544 bytes

Forgot the path inside. here's a fix.

nvahalik’s picture

nvahalik commented
Status: Needs review » Reviewed & tested by the community

  • nvahalik committed b2a8f21 on 7.x-2.x 
    Issue #1329520 by nvahalik: Refactor Views integration to use individual...
nvahalik’s picture

nvahalik commented
Status: Reviewed & tested by the community » Fixed

Fixed in 2.x.

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented

Could we do 1.x on this too?

  • nvahalik committed 93c97d5 on 7.x-1.x authored by joelpittet 
    Issue #2507949 by joelpittet: commerce_reorder_preprocess_link...
nvahalik’s picture

nvahalik commented

Done.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.