Problem/Motivation

Just noticed this javascript was being added to all my pages regardless of it being needed or not.

Proposed resolution

Attach it when needed.

Remaining tasks

User interface changes

API changes

CommentFileSizeAuthor
#1 attach-js-visualization-2507229-1.patch1.56 KBjoelpittet

Comments

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
Title: Don't add visualization.js on pages that don't need it. » Add visualization.js on pages that use it
Status: Active » Needs review
StatusFileSize
new attach-js-visualization-2507229-1.patch1.56 KB

It's a small file but potentially another request being made and object created that doesn't need to be there.

This should do the trick I'd expect.

Status: Needs review » Needs work

The last submitted patch, 1: attach-js-visualization-2507229-1.patch, failed testing.

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
Version: 7.x-1.x-dev » 7.x-1.0-beta1
Status: Needs work » Needs review

joelpittet queued 1: attach-js-visualization-2507229-1.patch for re-testing.

Status: Needs review » Needs work

The last submitted patch, 1: attach-js-visualization-2507229-1.patch, failed testing.

Niremizov’s picture

Niremizov commented
Category: Task » Bug report

  • Niremizov committed 03080f0 on 7.x-1.x authored by joelpittet 
    Issue #2507229 by joelpittet: Add visualization.js on pages that use it
Niremizov’s picture

Niremizov commented
Version: 7.x-1.0-beta1 » 8.x-1.x-dev
Niremizov’s picture

Niremizov commented
Version: 8.x-1.x-dev » 7.x-1.0-beta1
Status: Needs work » Fixed

Наve forgotten that this is already fixed for 8.x branch. So seems fixed now.

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented

Cool thanks

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.