Attach Save Grants button to user table and change Search button text?

First of all thanks for a great module that has been useful in several projects.

One thing that has me wondering - and has confused me as well as several users - is the presence of a "Save Grants" button when there are no grants to save - in other words when there is no user table.

People (myself included) will start typing a user name, select the appropriate name and push "Save Grants". Sure, there are no grants to save, that's pretty obvious, but having to press "Search" (which doesn't search, but adds the user to the table) and then "Save Grants" doesn't seem logical to me. There might be reasons for this structure that I haven't seen, but my experiments with moving it has led to no problems.

The "Search" button ought to be called "Add User" in my eyes and the "Save Grants" button ought not to be showed before there are actual grants to be saved.

The first is a simple text change, the second is a question of moving the submit button form item inside the block that starts in line 738 in nodeaccess.module

  // Users table.
  if (is_array($users)) {
    ...
  }

I have moved the button from the bottom of the form code and inside this block and added a trigger on the number of users, like this:

    if (count($users)) {
      $form['submit'] = array(
        '#type' => 'submit',
        '#value' => t('Save Grants'),
      );
    }

It seems to work and might be worth a consideration. It tightens up the UI and confuses fewer users.

Just a suggestion.

Martin