Problem/Motivation

\Drupal\Core\Plugin\Discovery\HookDiscovery sets the module key in definitions instead of provider.

Proposed resolution

Change module to provider.

Remaining tasks

None.

User interface changes

None.

API changes

None.

Beta phase evaluation

Reference: https://www.drupal.org/core/beta-changes
Issue category Bug because existing functionality is broken
Unfrozen changes Un-frozen because its API change for internal API
Prioritized changes The main goal of this issue is bug fix on Plugin system
Disruption Non disruptive because it only changes internal API
CommentFileSizeAuthor
#3 drupal_2504993_3.patch2.82 KBxano
#3 interdiff.txt2.15 KBxano
#1 drupal_2504993_1.patch692 bytesxano

Comments

xano’s picture

xano
he/they
Primary language English
Location Southampton
commented
Status: Active » Needs review
StatusFileSize
new drupal_2504993_1.patch692 bytes

Status: Needs review » Needs work

The last submitted patch, 1: drupal_2504993_1.patch, failed testing.

xano’s picture

xano
he/they
Primary language English
Location Southampton
commented
Status: Needs work » Needs review
StatusFileSize
new interdiff.txt2.15 KB
new drupal_2504993_3.patch2.82 KB
lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
commented
Issue summary: View changes
Status: Needs review » Reviewed & tested by the community

provider should be used instead of module so it makes change. I also added the beta evaluation.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Yes all other methods of discovery set a provider key and not a module key. Nice find. Committed 5a231af and pushed to 8.0.x. Thanks!

  • alexpott committed 5a231af on 8.0.x 
    Issue #2504993 by Xano: HookDiscovery sets "module" instead of "provider...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.