We don't need to throw an exception and fail, we can quietly skip the tests and allow a better experience.

CommentFileSizeAuthor
sqlite-skip-migration-tests.patch692 bytesneclimdul

Comments

lostkangaroo’s picture

lostkangaroo commented
Status: Needs review » Reviewed & tested by the community

This works for me since forcing a test failure on a missing extension in testing isn't really all that helpful.

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented

+1. This is much better DX than throwing an exception.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed 7918441 and pushed to 8.0.x. Thanks!

This change only affects tests and therefore can be made during beta.

  • alexpott committed 7918441 on 8.0.x 
    Issue #2504781 by neclimdul: Skip instead of fail migration tests if...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.