Problem/Motivation

CollectWebTest is broken because of #2481453: Implement query parameter based content negotiation as alternative to extensions. To make head green we temporary commented out some assertions related to fetching web resources in CollectWebTest. The interesting part is, that the problem only appears in tests and when we try to fetch web resource with application/json headers.

Proposed resolution

Not sure what is the resolution, but it might be a caching problem...

Remaining tasks

User interface changes

API changes

Comments

mbovan’s picture

Status: Active » Needs review
StatusFileSize
new1.88 KB

I'm uploading this patch just to see if it passes when we add debug() to the test module. If I am right, we had this problem before, but not sure how we solved it.
Maybe @Berdir can help with this.

mbovan’s picture

StatusFileSize
new1.55 KB

Made the patch too early.

The last submitted patch, 1: fix_fetchwebresource-2504485-1.patch, failed testing.

Status: Needs review » Needs work

The last submitted patch, 2: fix_fetchwebresource-2504485-2.patch, failed testing.

Status: Needs work » Needs review
arla’s picture

StatusFileSize
new981 bytes

This patch just removes the commenting, too see what the problem is.

Status: Needs review » Needs work

The last submitted patch, 6: fix_fetchwebresource-2504485-6.patch, failed testing.

arla’s picture

I'm uploading this patch just to see if it passes when we add debug() to the test module. If I am right, we had this problem before, but not sure how we solved it.

Perhaps you mean #2428765: Make entity export client/server-based? Patch #25 added debug(), #31 removed it and passed the tests. Not sure what was the actual solution.

Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 6: fix_fetchwebresource-2504485-6.patch, failed testing.

edurenye’s picture

Status: Needs work » Needs review
StatusFileSize
new1.48 KB
new532 bytes

Disabled the cache and it solved the errors in the tests.

mbovan’s picture

Status: Needs review » Reviewed & tested by the community

Looks like an easy fix. :D

miro_dietiker’s picture

Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.