Remove CMP access for new customers

1. +++ b/README.txt
   @@ -1,7 +1,7 @@
   +Integrates with the Mollom service: https://mollom.com
   

   Please refer to www.mollom.com instead of the non www version

2. +++ b/README.txt
   @@ -128,6 +137,5 @@ For questions pertaining to the Mollom service go to https://mollom.com/support
    * Dries Buytaert (Dries) - http://drupal.org/user/1
   

   Really? Is Dries still maintaining it? :) If you are making changes, perhaps add me (if you let me?) and remove Dries.

3. +++ b/mollom.admin.inc
   @@ -456,33 +456,45 @@ function mollom_admin_configure_form($form, &$form_state, $mollom_form = NULL) {
   +      if (mollom_cmp_enabled()) {
   

   a function in an if clause might not work in php versions < 5.4 (eg 5.3). Safer to set it to a variable and then do an if on that variable.

4. +++ b/mollom.admin.inc
   @@ -456,33 +456,45 @@ function mollom_admin_configure_form($form, &$form_state, $mollom_form = NULL) {
   +            '@moderation-url' => 'https://mollom.com/moderation',
   

   set www.mollom.com

5. +++ b/mollom.admin.inc
   @@ -456,33 +456,45 @@ function mollom_admin_configure_form($form, &$form_state, $mollom_form = NULL) {
   +            '@moderation-product' => 'Mollom Content Moderation Platform',
   

   Here you use the @ sign, and a bit further you use the % sign. Please be consistent when replacing variables in text.

6. +++ b/mollom.admin.inc
   @@ -456,33 +456,45 @@ function mollom_admin_configure_form($form, &$form_state, $mollom_form = NULL) {
   +          '#default_value' => (string) (int) ($mollom_form['moderation'] && $has_clean_urls),
   

   two times type casting? How does this make sense? What is this doing even? I like shorthand functions but this might need some explanation

7. +++ b/mollom.install
   @@ -302,7 +302,7 @@ function mollom_schema() {
   +        'description' => 'Whether to integrate with Mollom moderation - feature is deprecated.',
   

   You can CAPSLOCK this thing. It will only be visible in the mysql schema anyway, but having DEPRECATED doesn't leave much to the imagination heh.

8. +++ b/mollom.module
   @@ -3224,7 +3233,7 @@ function mollom_mollom_data_insert($data) {
   +  if (mollom_cmp_enabled() && !empty($mollom_form['moderation'])) {
   

   same thing as above, check if all php versions understand this syntax. When backporting to D6 you might end up with problems

9. +++ b/tests/mollom.test
   @@ -5629,9 +5638,7 @@ class MollomModerationIntegrationTestCase extends MollomModerationBaseTestCase {
   +   * @todo: Remove tests after Mollom CMP is retired on Oct. 1, 2015.
   

   Right, I can see us browsing this code somewhere end of 2016 and reading this. Should we already reference some issue queue # here to make sure it is actionable?

+++ b/mollom.install
@@ -1303,3 +1303,20 @@ function mollom_update_7213() {
+  foreach ($result as $moderation) {

one thing here is that you need to check if the result is an array and not empty. You will end up with errors otherwise.I don't think the db_query always gives you an array back? Might need to be checked

Aside of that it looks very good!