Here is the patch for usage of SafeMarkup class.
Tested at beta11.

CommentFileSizeAuthor
#2 useSafeMarkup.patch8.17 KBgokulnk
useSafeMarkup.patch6.16 KBalex43210

Comments

yukare’s picture

yukare commented
Priority: Normal » Critical
Status: Active » Needs work

This patch looks good, but it need more work, as there are another uses of String, running the tests with this path:

PHP Fatal error: Class 'Drupal\\Component\\Utility\\String' not found in /var/www/drupal8/public_html/modules/geshifilter/src/Form/GeshiFilterSettingsForm.php on line 321

gokulnk’s picture

gokulnk commented
StatusFileSize
new useSafeMarkup.patch8.17 KB

Changed the occurrence of String::checkPlain in all the files to SafeMarkup::checkPlain

yukare’s picture

yukare commented
Assigned: Unassigned » yukare

We still have some uses of String:

Class 'Drupal\geshifilter\Plugin\Filter\String' not found PHP Fatal error GeshiFilterFilter.php 692 Unknown

I will work on this.

  • yukare committed af32177 on 8.x-1.x 
    Issue #2501959 by alex43210, gokulnk, yukare: In version from beta10...
yukare’s picture

yukare commented
Title: In version from beta10 class String removed, so it's need to use SafeMarkup class » In version from beta10 class String removed
Status: Needs work » Fixed

I fixed the last missing String:: and commited the fix to git, thanks for all the help.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.