Problem/Motivation

Usage of router builder in Drupal\Core\Menu\LocalTaskManager was removed in #356399: Optimize the route rebuilding process to rebuild on write but the service is still injected

Proposed resolution

Remove the router builder service from Drupal\Core\Menu\LocalTaskManager

User interface changes

none

API changes

none

Beta phase evaluation

Reference: https://www.drupal.org/core/beta-changes
Issue category Task because we are removing dead code.
Issue priority Normal because Drupal will work whether or not it is removed.
Prioritized changes The main goal of this issue is removing dead code, and should be a prioritized change
Disruption Disruptive for any classes that extend LocalTaskManager, which will need to update their constructors.
CommentFileSizeAuthor
#5 interdiff.txt2.33 KBwillzyx
#5 remove_unused-2501355-5.patch7.91 KBwillzyx
#3 remove_unused-2501355-3.patch5.41 KBwillzyx
#3 interdiff.txt785 byteswillzyx
#1 remove_unused-2501355-1.patch4.5 KBwillzyx
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

willzyx’s picture

willzyx CreditAttribution: willzyx commented
Status: Active » Needs review
FileSize
remove_unused-2501355-1.patch4.5 KB

Status: Needs review » Needs work

The last submitted patch, 1: remove_unused-2501355-1.patch, failed testing.

willzyx’s picture

willzyx CreditAttribution: willzyx commented
Status: Needs work » Needs review
FileSize
interdiff.txt785 bytes
remove_unused-2501355-3.patch5.41 KB

Removed dead code in tests

Status: Needs review » Needs work

The last submitted patch, 3: remove_unused-2501355-3.patch, failed testing.

willzyx’s picture

willzyx CreditAttribution: willzyx commented
FileSize
remove_unused-2501355-5.patch7.91 KB
interdiff.txt2.33 KB

Removed more unused/untested code in tests

willzyx’s picture

willzyx CreditAttribution: willzyx commented
Status: Needs work » Needs review
dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner as a volunteer and at Tag1 Consulting commented
Status: Needs review » Reviewed & tested by the community

Good catch!

willzyx’s picture

willzyx CreditAttribution: willzyx commented
Issue summary: View changes

Added beta evaluation

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Chapter Three commented
Status: Reviewed & tested by the community » Fixed

Nice find. Committed 78f0760 and pushed to 8.0.x. Thanks!

  • alexpott committed 78f0760 on 8.0.x 
    Issue #2501355 by willzyx: Remove unused router.builder service from...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.