I noticed a small issue... I have an IRC room that mixes uppercase and lowercase (#farmOS). I entered that room name in the Bot module settings, and it connects fine to the room. However, when I say "log pointer?" it spits out the url with the room name all lowercase. Clicking on that link gives an access denied. If I change the URL to include the uppercase letters, it works.

This is what Bot prints, which does NOT work:

http://farmos.org/bot/log/farmos/2015-06-02#T4664

This is what Bot SHOULD print, which works:

http://farmos.org/bot/log/farmOS/2015-06-02#T4664

CommentFileSizeAuthor
#1 bot_log_case_sensitivity-2498967-1.patch1.42 KBm.stenta

Comments

m.stenta’s picture

m.stenta
he/him
Primary language English
commented
Status: Active » Needs review
StatusFileSize
new bot_log_case_sensitivity-2498967-1.patch1.42 KB

Attached is a patch that fixes this.

It looks like the room name is being converted to lowercase for comparison with the list of logged rooms. That makes sense. But then it is using that lowercased name for generating the URL.

This patch continues to lowercase for comparison, but uses the original room name in printed messages.