Currently it appears nodes are sorted ascending by nid when displayed in the webform. It would be great to have the option to sort alphabetically by title, ascending or descending.

CommentFileSizeAuthor
#13 webform_references-term_sort_by_weight_2498937_13.patch665 bytesyaach

Comments

Poieo’s picture

Poieo commented

Looks like adding

->orderBy('title', 'ASC')

to

function _webform_references_get_node_list($types)

in webform_references.node.inc will force sorting by node title. But, it may be better to give the option.

sumitmadan’s picture

sumitmadan commented

Yes, we should make sorting configurable. I will work on this soon.

See, if you can work on this. :)

  • sumitmadan committed e25b7ea on 7.x-1.x 
    Issue #2498937: Configuration for sort by Title/Id
sumitmadan’s picture

sumitmadan commented
Status: Active » Fixed

Committed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

yaach’s picture

yaach commented

What about if we dont want to apply any sorting to the list? I want my taxonomy term list to appear in a specific order, but I can't now since by default it is sorted by id or title.

I think sorting should be an option, not set as default or mandatory.

yaach’s picture

yaach commented
Status: Closed (fixed) » Needs review
sumitmadan’s picture

sumitmadan commented
Status: Needs review » Closed (fixed)

It is the default behavior or sorting of taxonomy terms. If we do not provide any sorting order by default it sorts by id.

yaach’s picture

yaach commented

Ok so in other words, the order will depend on the "order" the terms are entered, one after another. It would be useful to keep the order you can choose by dragging and dropping the cross icons on a term list. If you want a term that was entered last to be displayed second, you just drag that term and drop in the second place, then save. That order should be kept into webform_references.

yaach’s picture

yaach commented

Any updates on this? ...from my last comment.

yaach’s picture

yaach commented
Status: Closed (fixed) » Needs review
sumitmadan’s picture

sumitmadan commented
Status: Needs review » Closed (fixed)

@yalgeria,

There is another feature request for sort by weight option. See if you can work on it. Here is the link : #2564775: Sort Terms by Weight?

yaach’s picture

yaach commented
StatusFileSize
new webform_references-term_sort_by_weight_2498937_13.patch665 bytes

Nevermind, think I was able to add the weight element to be sorted...easy fix..please take a look...now it works nice!.

yaach’s picture

yaach commented
Status: Closed (fixed) » Needs review

Status: Needs review » Needs work

The last submitted patch, 13: webform_references-term_sort_by_weight_2498937_13.patch, failed testing.

sumitmadan’s picture

sumitmadan commented
Status: Needs work » Closed (fixed)

Please upload your patch to respective issue. Also I believe you are using old codebase, so please create patch against latest dev branch.

yaach’s picture

yaach commented

This is what i am cloning from:

git clone --branch 7.x-1.x http://git.drupal.org/project/webform_references.git

Is that wrong?

sumitmadan’s picture

sumitmadan commented

@yalgeria Aaah!!! no. Sorry my bad. Its because of version selected in the issue. Also in future, please upload your patch on specific issue or if its not there then create one.

yaach’s picture

yaach commented

Ok realized somebody else has the same patch on #2564775. Anyway. Thanks