Problem/Motivation

We don't have a maintainer for classy theme.

Proposed resolution

Add davidhernandez and mortendk as maintainers for Classy.

Remaining tasks

User interface changes

API changes

CommentFileSizeAuthor
#19 add_a_maintainer_for-2496789-19.patch565 byteslauriii
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

mortendk’s picture

Issue summary: View changes
davidhernandez’s picture

Issue tags: +Project governance

Yeah, we should update maintainers.txt, either now or when (?) the whole governance re-evaluation is suppose to happen. Do we also need to add someone else to Stark? I'm not sure if John cares about babysitting it, or if it really needs any attention.

webchick’s picture

Feel free to propose individual updates to MAINTAINERS.txt. Doing a wholesale revamp of it is on my todo list, but it's not at the top. :)

aburrows’s picture

I'm happy to be a maintainer of this theme, it looks like a challenge i'm ready to accept as well as working more in contributing to core patches. Looking to start dedicating more time to core and working on core every friday as well.

mortendk’s picture

Stark in its original form "is dead" BUT its deeply connected to classy - if we look at the context of the banana concensus, maybe this is a talk we should have at the next drupaltwig call ? - so we have a plan moving forward

lauriii’s picture

Thanks Morten for creating issue for this. This is important thing to decide. I don't know if you're up to this Morten but I would really like to see you as a maintainer of Classy.

I think there is multiple reasons why we should have him as a maintainer (if he wishes so). He has a great vision what Classy should be and what it is - something that I don't think any of us have. Morten has also ability to organize sprints like in Amsterdam pre-post sprints. He has been also very active in the issues related to Classy. So I wish he would be at least one of the maintainers (if multiple)!

mortendk’s picture

@lauri - yes I would be up for the task, if the drupal themers want me to be offcouse

LewisNyman’s picture

I would like to propose davidhernandez as maintainer of the Classy theme. He's been ever-present throughout the Classy/banana implementation process. He's well organised and a good leader.

Do we also need to add someone else to Stark?

I don't consider John to be active, we definitely need someone to add or replace him. We could also discuss weather Stark needs a maintainer at all, as it's basically an empty theme. I think an active 'markup' maintainer is more pressing.

davidhernandez’s picture

I'd be happy to do it. Classy has been my main impetus for core contribution, so there is some personal attachment there, and it is great to be recognized for the hard work. However, I don't want to overlook Morten's vision for D8 frontend, and helping get us where we are today.

I have another proposal. Since it behooves us to have more than one maintainer for each component, how about adding us both? Morten is more fiery than I am, and I like to think I'm a bit more level-headed, yet we seem to get along and work together just fine. :)

I have some more thoughts about the other theme system components, and was hoping to discuss it some during last nights Twig call, but it was just me, Joel, and Emma. If more people are available at the next one, perhaps we should set aside some time for this.

Governance is a bit boring for some, but these matters are important. We need to make sure we have good leadership and clear procedures in place, and are recognizing people for the work they are currently doing.

lauriii’s picture

I was just about to comment on the issue earlier today that what about having David and Morten both. They both have reasons why they should be maintainers, Morten has a great vision and is good at hiring people to work on it, on the other hand David has also good vision and has very good skills on organizing things. So +1 for having Morten and David both as a maintainer for Classy.

mortendk’s picture

that would be a good combination tbh a cool n calm dane & a fiery american ;)
btw could we go back to weekly twig calls - cause my calender is messing with me

star-szr’s picture

We can do weekly as long as it's not me hosting every week, I can't commit to that. We were talking a few days ago on IRC about trying to set up a shared
YouTube/Google+ account.

mortendk’s picture

sounds like a good idea, i have trouble with half of em cause of daddy responsibiltys ;)
- but i can defently host on the eu side

LewisNyman’s picture

The maintainers.txt is not intended to be for credit, so we shouldn't use it to recognise work people have already done, we have other nice ways of doing that ;-)

We should only add people as maintainers if they intend to commit to the role going forward. I think we can have two maintainers but only if they both intend to be active.

mortendk’s picture

@lewis why would anybody step forward as maintainers if they don't wanna maintain & use time on it going forward - its not a crown/medal - its a work task & commitment & leadership.
Without the vision & buy-in - we will loose the conceptual discussions that have been done over the last 3-4 years. btw you do know that Classy theme didn't come out magically because of a discussion over a banana ;)

LewisNyman’s picture

Sorry, I was commenting on #9 in particular:

it is great to be recognized for the hard work. However, I don't want to overlook Morten's vision for D8 frontend, and helping get us where we are today.

mortendk’s picture

check no harm done - but yes its not a price we hand out
... its more a punishment ;)

davidhernandez’s picture

Sorry, I did not mean to imply it can be used strictly as a reward for past deeds. I agree with the sentiment that every maintainer must be active in their area.

lauriii’s picture

Title: Add a maintainer for Classy theme » Add davidhernandez and mortendk as maintainers for Classy theme
Issue summary: View changes
Status: Active » Needs review
FileSize
565 bytes
YesCT’s picture

in #3 @webchick mentioned a revamp. I think #1854480: Remove inactive maintainers from MAINTAINERS.txt is where that is being tracked.

star-szr’s picture

@lauriii pointed out on IRC, the placement is alphabetical :)

Fabianx’s picture

Status: Needs review » Reviewed & tested by the community

Looks great!

tim.plunkett’s picture

+++ b/core/MAINTAINERS.txt
@@ -472,6 +472,10 @@ Bartik theme
+- Morten Birch Heide-Jørgensen 'mortendk' https://www.drupal.org/u/mortendk

Shouldn't that be Morten--Birch__Heide-Jørgensen? :)

+1 for both David and Morten!

Manjit.Singh’s picture

+2 for both David and Morten !! :D

webchick’s picture

Assigned: Unassigned » Dries

Woohoo!

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 19: add_a_maintainer_for-2496789-19.patch, failed testing.

Status: Needs work » Needs review
Fabianx’s picture

Status: Needs review » Reviewed & tested by the community

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 19: add_a_maintainer_for-2496789-19.patch, failed testing.

Status: Needs work » Needs review
davidhernandez’s picture

Status: Needs review » Reviewed & tested by the community

No idea why random test fail.

Dries’s picture

Assigned: Dries » Unassigned
Status: Reviewed & tested by the community » Fixed

Committed to 8.x. @davidhernandez and @mortendk; thanks for all your work and stepping up to being a maintainer for this theme!

  • Dries committed a2e1d70 on 8.0.x
    Issue #2496789 by lauriii: Add davidhernandez and mortendk as...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.