Problem/Motivation

Initially brought up in Convert theme_views_ui_build_group_filter_form() to Twig, but deemed out of scope.

In the Grouped filters table, there is a default checkbox and radio button, only one of which is available depending on whether the mode is set to allow multiple selections or a single selection. They are properly hidden however both of their labels are always shown.

Proposed resolution

Patch attached, fixes that.

CommentFileSizeAuthor
#9 after.png21.87 KBolli
#9 before.png23.2 KBolli
#9 2496501-9.patch1.54 KBolli
#6 interdiff.txt1.59 KBolli
#6 grouped-2496501-6.patch1.55 KBolli
#1 grouped-2496501-1.patch935 bytesNickDickinsonWilde
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

NickDickinsonWilde’s picture

NickDickinsonWilde
He/Him/His
Primary language English
Location Victoria, BC (T'So-uke lands)
CreditAttribution: NickDickinsonWilde commented
FileSize
grouped-2496501-1.patch935 bytes
joelpittet’s picture

joelpittet
Primary language English
Location Vancouver
CreditAttribution: joelpittet commented

This may also fix it? #2489826: tabledrag is broken

olli’s picture

olli CreditAttribution: olli commented
Status: Active » Needs review
Issue tags: +VDC, +JavaScript

@joelpittet: This is about the double labels when configuring a grouped filter (edit frontpage view, click "Content: Publishing status (grouped)" below filter criteria, try un/checking "Allow multiple selections").

joelpittet’s picture

joelpittet
Primary language English
Location Vancouver
CreditAttribution: joelpittet commented

@olli ah thanks for clarifying.

droplet’s picture

droplet CreditAttribution: droplet commented
  • +++ b/core/modules/views_ui/js/views-admin.js
    @@ -836,13 +836,13 @@
    + $('input.default-checkboxes').parent().hide()

    Missing `;`

  • All jQuery queries in `Drupal.behaviors.viewsUiChangeDefaultWidget` should be limited the scope to this form only.

----
Some Issues I've seen and can be fix in new threads (please pointed me to there if it's an issue opened already):

  • Hidden checkbox / radio box in this way is dirty markups and breaking accessibility I think.
  • vertical aligned radio selection in same column would looks better
  • Grouped filters, next to radio/checbox with label `Grouping 1`, `Grouping 2`, `Grouping 3`, not easy to understand what it is...
olli’s picture

olli CreditAttribution: olli commented
FileSize
grouped-2496501-6.patch1.55 KB
interdiff.txt1.59 KB

Fixed #5, thanks @droplet.
----
There's #2387353: Improve form element labels in views grouped filter for labels, not sure about the other points.

Hidden checkbox / radio box in this way is dirty markups and breaking accessibility I think.

Here we want to replace checkboxes with radios when user should select only one default value, and replace radios with checkboxes to allow selecting multiple default values. What is the right way to do that?

vertical aligned radio selection in same column would looks better

Maybe also change the order of Default and Label columns?

Grouped filters, next to radio/checbox with label `Grouping 1`, `Grouping 2`, `Grouping 3`, not easy to understand what it is...

I agree. Any ideas how to improve that?

droplet’s picture

droplet CreditAttribution: droplet commented
Status: Needs review » Reviewed & tested by the community

Improve in #6 looks good and fixing the problems.

@olli,
I have no good idea for other issues yet :)

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Chapter Three commented
Status: Reviewed & tested by the community » Needs work
Issue tags: +Needs screenshots

I've tried to manually test this but there is quite a bit wrong with this form so it'd be great to have screenshot so I can see what this is fixing. Sorry for being dumb.

olli’s picture

olli CreditAttribution: olli commented
Issue summary: View changes
Status: Needs work » Reviewed & tested by the community
Issue tags: -Needs screenshots
FileSize
2496501-9.patch1.54 KB
before.png23.2 KB
after.png21.87 KB

Reroll and screenshots.

olli’s picture

olli CreditAttribution: olli commented

Found #2503691: Checkboxes and radios rendered twice in views ui grouped filters form while taking those screenshots.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Chapter Three commented
Status: Reviewed & tested by the community » Fixed

Committed 8d9f1ea and pushed to 8.0.x. Thanks!

  • alexpott committed 8d9f1ea on 8.0.x 
    Issue #2496501 by olli, NickWilde: Grouped Filters Javascript...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.