| #211 | work.patch | 71.24 KB | plach |
| #210 | work.patch | 109.7 KB | plach |
| #209 | work.patch | 133.3 KB | plach |
| #208 | work.patch | 124.38 KB | plach |
| #206 | work.patch | 3.06 KB | plach |
| #204 | work.patch | 3.08 KB | plach |
| #203 | work.patch | 4.04 KB | plach |
| #201 | work.patch | 124.38 KB | plach |
| #198 | work.patch | 120.45 KB | plach |
| #196 | work.patch | 114.91 KB | plach |
| #194 | work.patch | 23.22 KB | plach |
| #193 | work.patch | 162.19 KB | plach |
| #191 | work.patch | 20.55 KB | plach |
| #188 | work.patch | 15.14 KB | plach |
| #187 | work.patch | 0 bytes | plach |
| #185 | work.patch | 158.83 KB | plach |
| #182 | work.patch | 159.83 KB | plach |
| #181 | work.patch | 159.68 KB | plach |
| #179 | work.patch | 15.79 KB | plach |
| #178 | work.patch | 141.42 KB | plach |
| #176 | work.patch | 138.34 KB | plach |
| #176 | work.patch | 138.34 KB | plach |
| #174 | work.patch | 144.27 KB | plach |
| #171 | work.patch | 144.16 KB | plach |
| #170 | work.patch | 142.9 KB | plach |
| #168 | work.patch | 142.88 KB | plach |
| #166 | work.patch | 25.6 KB | plach |
| #164 | work.patch | 16.71 KB | plach |
| #163 | work.patch | 20.38 KB | plach |
| #161 | work.patch | 20.38 KB | plach |
| #159 | work.patch | 16 KB | plach |
| #158 | work.patch | 125.38 KB | plach |
| #156 | work.patch | 125.11 KB | plach |
| #155 | work.patch | 117.93 KB | plach |
| #153 | work.patch | 110.61 KB | plach |
| #151 | work.patch | 110.36 KB | plach |
| #149 | work.patch | 108.9 KB | plach |
| #147 | work.patch | 107.09 KB | plach |
| #145 | work.patch | 105.44 KB | plach |
| #143 | work.patch | 104.75 KB | plach |
| #141 | work.patch | 101.18 KB | plach |
| #138 | work.patch | 95.76 KB | plach |
| #137 | work.patch | 94.95 KB | plach |
| #136 | work.patch | 64.66 KB | plach |
| #135 | work.patch | 36.68 KB | plach |
| #134 | work.patch | 1.58 KB | plach |
| #132 | work.patch | 1.55 KB | plach |
| #130 | work.patch | 16.43 KB | plach |
| #129 | work.patch | 18.88 KB | plach |
| #125 | work.patch | 3.29 KB | plach |
| #122 | 2382675-2-122.patch | 24.16 KB | alexpott |
| #122 | 2382675-2-122.patch | 24.16 KB | alexpott |
| #122 | 2382675-2-122.patch | 24.16 KB | alexpott |
| #122 | 2382675-2-122.patch | 24.16 KB | alexpott |
| #122 | 2382675-2-122.patch | 24.16 KB | alexpott |
| #122 | 2382675-2-122.patch | 24.16 KB | alexpott |
| #122 | 2382675-2-122.patch | 24.16 KB | alexpott |
| #122 | 2382675-2-122.patch | 24.16 KB | alexpott |
| #122 | 2382675-2-122.patch | 24.16 KB | alexpott |
| #122 | 2382675-2-122.patch | 24.16 KB | alexpott |
| #122 | 2382675-2-122.patch | 24.16 KB | alexpott |
| #122 | 2382675-2-122.patch | 24.16 KB | alexpott |
| #110 | plach-test-110.patch | 20.53 KB | alexpott |
| #110 | plach-test-110.patch | 20.53 KB | alexpott |
| #110 | plach-test-110.patch | 20.53 KB | alexpott |
| #110 | plach-test-110.patch | 20.53 KB | alexpott |
| #110 | plach-test-110.patch | 20.53 KB | alexpott |
| #110 | plach-test-110.patch | 20.53 KB | alexpott |
| #110 | plach-test-110.patch | 20.53 KB | alexpott |
| #110 | plach-test-110.patch | 20.53 KB | alexpott |
| #110 | plach-test-110.patch | 20.53 KB | alexpott |
| #110 | plach-test-110.patch | 20.53 KB | alexpott |
| #110 | plach-test-110.patch | 20.53 KB | alexpott |
| #110 | 109-110-interdiff.txt | 2.71 KB | alexpott |
| #109 | et-translation_create-2382675-work.patch | 21.27 KB | plach |
| #109 | et-translation_create-2382675-work.patch | 21.27 KB | plach |
| #109 | et-translation_create-2382675-work.patch | 21.27 KB | plach |
| #109 | et-translation_create-2382675-work.patch | 21.27 KB | plach |
| #109 | et-translation_create-2382675-work.patch | 21.27 KB | plach |
| #109 | et-translation_create-2382675-work.patch | 21.27 KB | plach |
| #109 | et-translation_create-2382675-work.patch | 21.27 KB | plach |
| #109 | et-translation_create-2382675-work.patch | 21.27 KB | plach |
| #109 | et-translation_create-2382675-work.patch | 21.27 KB | plach |
| #109 | et-translation_create-2382675-work.patch | 21.27 KB | plach |
| #107 | et-translation_create-2382675-work.patch | 21.21 KB | plach |
| #107 | et-translation_create-2382675-work.patch | 21.21 KB | plach |
| #107 | et-translation_create-2382675-work.patch | 21.21 KB | plach |
| #107 | et-translation_create-2382675-work.patch | 21.21 KB | plach |
| #107 | et-translation_create-2382675-work.patch | 21.21 KB | plach |
| #102 | et-translation_create-2382675-work.patch | 20.78 KB | plach |
| #102 | et-translation_create-2382675-work.patch | 20.78 KB | plach |
| #102 | et-translation_create-2382675-work.patch | 20.78 KB | plach |
| #102 | et-translation_create-2382675-work.patch | 20.78 KB | plach |
| #102 | et-translation_create-2382675-work.patch | 20.78 KB | plach |
| #102 | et-translation_create-2382675-work.patch | 20.78 KB | plach |
| #102 | et-translation_create-2382675-work.patch | 20.78 KB | plach |
| #102 | et-translation_create-2382675-work.patch | 20.78 KB | plach |
| #102 | et-translation_create-2382675-work.patch | 20.78 KB | plach |
| #102 | et-translation_create-2382675-work.patch | 20.78 KB | plach |
| #100 | et-translation_create-2382675-work.patch | 20.59 KB | plach |
| #100 | et-translation_create-2382675-work.patch | 20.59 KB | plach |
| #100 | et-translation_create-2382675-work.patch | 20.59 KB | plach |
| #100 | et-translation_create-2382675-work.patch | 20.59 KB | plach |
| #100 | et-translation_create-2382675-work.patch | 20.59 KB | plach |
| #93 | et-translation_create-2382675-work.patch | 20.54 KB | plach |
| #93 | et-translation_create-2382675-work.patch | 20.54 KB | plach |
| #93 | et-translation_create-2382675-work.patch | 20.54 KB | plach |
| #93 | et-translation_create-2382675-work.patch | 20.54 KB | plach |
| #93 | et-translation_create-2382675-work.patch | 20.54 KB | plach |
| #89 | et-translation_create-2382675-work.patch | 20.52 KB | plach |
| #89 | et-translation_create-2382675-work.patch | 20.52 KB | plach |
| #89 | et-translation_create-2382675-work.patch | 20.52 KB | plach |
| #89 | et-translation_create-2382675-work.patch | 20.52 KB | plach |
| #89 | et-translation_create-2382675-work.patch | 20.52 KB | plach |
| #88 | et-translation_create-2382675-work.patch | 20.54 KB | plach |
| #88 | et-translation_create-2382675-work.patch | 20.54 KB | plach |
| #88 | et-translation_create-2382675-work.patch | 20.54 KB | plach |
| #88 | et-translation_create-2382675-work.patch | 20.54 KB | plach |
| #88 | et-translation_create-2382675-work.patch | 20.54 KB | plach |
| #85 | et-translation_create-2382675-work.patch | 20.53 KB | plach |
| #85 | et-translation_create-2382675-work.patch | 20.53 KB | plach |
| #85 | et-translation_create-2382675-work.patch | 20.53 KB | plach |
| #85 | et-translation_create-2382675-work.patch | 20.53 KB | plach |
| #85 | et-translation_create-2382675-work.patch | 20.53 KB | plach |
| #84 | et-translation_create-2382675-40.patch | 20.53 KB | plach |
| #84 | et-translation_create-2382675-40.patch | 20.53 KB | plach |
| #84 | et-translation_create-2382675-40.patch | 20.53 KB | plach |
| #84 | et-translation_create-2382675-40.patch | 20.53 KB | plach |
| #84 | et-translation_create-2382675-40.patch | 20.53 KB | plach |
| #83 | et-translation_create-2382675-work.patch | 16.86 KB | plach |
| #83 | et-translation_create-2382675-work.patch | 16.86 KB | plach |
| #83 | et-translation_create-2382675-work.patch | 16.86 KB | plach |
| #83 | et-translation_create-2382675-work.patch | 16.86 KB | plach |
| #83 | et-translation_create-2382675-work.patch | 16.86 KB | plach |
| #81 | et-translation_create-2382675-work.patch | 9.22 KB | plach |
| #81 | et-translation_create-2382675-work.patch | 9.22 KB | plach |
| #81 | et-translation_create-2382675-work.patch | 9.22 KB | plach |
| #81 | et-translation_create-2382675-work.patch | 9.22 KB | plach |
| #81 | et-translation_create-2382675-work.patch | 9.22 KB | plach |
| #80 | et-translation_create-2382675-work.patch | 14.08 KB | plach |
| #80 | et-translation_create-2382675-work.patch | 14.08 KB | plach |
| #80 | et-translation_create-2382675-work.patch | 14.08 KB | plach |
| #80 | et-translation_create-2382675-work.patch | 14.08 KB | plach |
| #80 | et-translation_create-2382675-work.patch | 14.08 KB | plach |
| #79 | et-translation_create-2382675-work.patch | 16.86 KB | plach |
| #79 | et-translation_create-2382675-work.patch | 16.86 KB | plach |
| #79 | et-translation_create-2382675-work.patch | 16.86 KB | plach |
| #79 | et-translation_create-2382675-work.patch | 16.86 KB | plach |
| #78 | et-translation_create-2382675-work.patch | 16.86 KB | plach |
| #75 | 2072945-work.patch | 13.15 KB | plach |
| #72 | 2072945-work.patch | 11.38 KB | plach |
| #70 | 2072945-work.patch | 74.43 KB | plach |
| #66 | 2072945-work.patch | 48.78 KB | plach |
| #64 | 2072945-work.patch | 50.93 KB | plach |
| #62 | 2072945-work.patch | 43.18 KB | plach |
| #60 | 2072945-work.patch | 41.62 KB | plach |
| #57 | 2072945-work.patch | 49.16 KB | plach |
| #51 | 2090983-work.patch | 76.91 KB | plach |
| #49 | 2090983-work.patch | 1.02 KB | plach |
| #44 | 2072945-work.patch | 47.83 KB | plach |
| #41 | 2072945-work.patch | 12.11 KB | plach |
| #39 | 2090983-work.patch | 1.5 KB | plach |
| #38 | entity-rm_auto_updates-2542748-work.patch | 12.25 KB | plach |
| #36 | entity-rm_auto_updates-2542748-work.patch | 41.45 KB | plach |
| #35 | entity-rm_auto_updates-2542748-work.patch | 43.81 KB | plach |
| #33 | entity-rm_auto_updates-2542748-work.patch | 990 bytes | plach |
| #32 | entity-rm_auto_updates-2542748-work.patch | 0 bytes | plach |
| #26 | work.patch | 32.25 KB | plach |
| #25 | work.patch | 28.52 KB | plach |
| #24 | work.patch | 27.36 KB | plach |
| #22 | work.patch | 27.7 KB | plach |
| #21 | field-item_callbacks-2496337-21.patch | 22.06 KB | plach |
| #21 | field-item_callbacks-2496337-21.interdiff.txt | 5.71 KB | plach |
| #20 | field-item_callbacks-2496337-20.interdiff.txt | 411 bytes | plach |
| #20 | field-item_callbacks-2496337-20.patch | 18.71 KB | plach |
| #17 | field-item_callbacks-2496337-17.patch | 18.71 KB | plach |
| #16 | field-item_callbacks-2496337-16.patch | 18.66 KB | plach |
| #16 | field-item_callbacks-2496337-16.interdiff.txt | 1004 bytes | plach |
| #14 | field-item_callbacks-2496337-14.interdiff.txt | 560 bytes | plach |
| #14 | field-item_callbacks-2496337-14.patch | 18.66 KB | plach |
| #12 | field-item_callbacks-2496337-12.patch | 18.65 KB | plach |
| #12 | field-item_callbacks-2496337-12.interdiff.txt | 5.28 KB | plach |
| #9 | field-item_callbacks-2496337-9-ok.patch | 16.14 KB | plach |
| #9 | field-item_callbacks-2496337-9.patch | 16.13 KB | plach |
| #9 | field-item_callbacks-2496337-9.interdiff.txt | 3.11 KB | plach |
| #6 | field-item_callbacks-2496337-6.patch | 16.21 KB | plach |
| #6 | field-item_callbacks-2496337-6.interdiff.txt | 1.08 KB | plach |
| #4 | log-fic-1.pdf | 44.67 KB | plach |
| #3 | field-item_callbacks-2496337-3.patch | 16.22 KB | plach |
| #3 | field-item_callbacks-2496337-3.interdiff.txt | 10.27 KB | plach |
| #1 | field-item_callbacks-2496337-1.patch | 8.46 KB | plach |
Comments
Comment #1
plachRerolled #2023473-5: Merge FieldItem::insert() and FieldItem::update() on fields into preSave() to see how many failures we have for now.
Comment #3
plachAdded ::postSave() method after discussing this with @Berdir (see attached log).
Comment #4
plachThe attached log :)
Comment #6
plachOf course
Comment #8
plachComment #9
plachThis should fix some failures. Attaching also the "correct" version, as so far I posted patches re-saving all field values all the time to ensure we are not breaking things in that case.
Comment #12
plachFixed PathItem.
Comment #14
plachAnother fix
Comment #16
plachThis should fix some other failures.
Comment #17
plachCorrect patch
Comment #20
plachJust curious to see whether all the current test failures are caused by rewriting field values. Disregard this patch, I will restore this line when I can get a green patch when always rewriting field values.
Comment #21
plachThis reverts #20 and attempts to fix all pending failures. Let's see.
Comment #22
plachComment #24
plachComment #25
plachComment #26
plachComment #27
plachComment #29
plachComment #30
plachComment #31
plachComment #32
plachComment #33
plachComment #35
plachComment #36
plach(note for myself, commit id: 5e2c5d78e3f95bce635da6a7c2f40910e1a70703)
Comment #38
plachComment #39
plachComment #40
plachComment #41
plachComment #44
plachComment #45
plachComment #47
plachComment #49
plachComment #51
plachComment #57
plachComment #60
plachComment #62
plachComment #64
plachComment #66
plachComment #70
plachComment #72
plachComment #75
plachComment #76
andypostlooks that becomes harder to catch within current implementation
Comment #77
plachComment #78
plachComment #79
plachComment #80
plachComment #81
plachComment #83
plachComment #84
plachComment #85
plachComment #88
plachComment #89
plachComment #93
plachComment #100
plachComment #102
plachComment #107
plachComment #109
plachComment #110
alexpottI don't trust traits and reflection.
Comment #122
alexpottHere's a patch that jiggles the interface around to make more sense.
Comment #125
plachComment #126
plachComment #129
plachComment #130
plachComment #132
plachComment #134
plachComment #135
plachComment #136
plachComment #137
plachComment #138
plachComment #141
plachComment #143
plachComment #145
plachComment #147
plachComment #149
plachComment #151
plachComment #153
plachComment #155
plachComment #156
plachComment #158
plachComment #159
plachComment #161
plachComment #163
plachComment #164
plachComment #166
plachComment #168
plachComment #170
plachComment #171
plachComment #174
plachComment #176
plachComment #178
plachComment #179
plachComment #181
plachComment #182
plachComment #185
plachComment #187
plachComment #188
plachComment #191
plachComment #193
plachComment #194
plachComment #196
plachComment #197
plachComment #198
plachComment #201
plachComment #203
plachComment #204
plachComment #206
plachComment #208
plachComment #209
plachComment #210
plachComment #211
plachComment #213
plach