Problem/Motivation

The MenuLinkContentUITest should actually be named MenuLinkContentTranslationUITest as it tests the translation UI. This would be more consistent and would make it easier to find this test when filtering the test list from the UI.

Proposed resolution

Do it

Remaining tasks

Do it

User interface changes

None

API changes

MenuLinkContentUITest renamed to MenuLinkContentTranslationUITest

CommentFileSizeAuthor
#5 menu_link_content-test_rename-2494767-5.patch1.66 KBplach
#4 menu_link_content-test_rename-2494767-4.patch1.48 KBplach
#3 menu_link_content-test_rename-2494767-3.patch1.26 KBplach
#1 menu_link_content-test_rename-2494767-1.patch1.1 KBplach

Comments

plach’s picture

plach
he/him
Primary language Italian
Location Venezia
commented
Status: Active » Needs review
Issue tags: +easy fix
StatusFileSize
new menu_link_content-test_rename-2494767-1.patch1.1 KB

Status: Needs review » Needs work

The last submitted patch, 1: menu_link_content-test_rename-2494767-1.patch, failed testing.

plach’s picture

plach
he/him
Primary language Italian
Location Venezia
commented
Status: Needs work » Needs review
StatusFileSize
new menu_link_content-test_rename-2494767-3.patch1.26 KB

bah

plach’s picture

plach
he/him
Primary language Italian
Location Venezia
commented
StatusFileSize
new menu_link_content-test_rename-2494767-4.patch1.48 KB

This should be better

plach’s picture

plach
he/him
Primary language Italian
Location Venezia
commented
StatusFileSize
new menu_link_content-test_rename-2494767-5.patch1.66 KB

It wasn't, PHPStorm--

The last submitted patch, 3: menu_link_content-test_rename-2494767-3.patch, failed testing.

The last submitted patch, 4: menu_link_content-test_rename-2494767-4.patch, failed testing.

Status: Needs review » Needs work

The last submitted patch, 5: menu_link_content-test_rename-2494767-5.patch, failed testing.

Status: Needs work » Needs review

Gábor Hojtsy queued 5: menu_link_content-test_rename-2494767-5.patch for re-testing.

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Status: Needs review » Reviewed & tested by the community

The fail on the local test looks unrelated. Should pass now. I also got puzzled by the naming of this test before but did not venture to submit a patch.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed d75dc26 and pushed to 8.0.x. Thanks!

  • alexpott committed d75dc26 on 8.0.x 
    Issue #2494767 by plach: Rename MenuLinkContentUITest to...
gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Issue tags: -sprint

Yay, thanks.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.