Update MAINTAINERS.txt to use human URLs

Mh, so this makes things a little bit more tricky in case someone decides to rename themselves.

Yeah... not sure about this either. What happens on d.o to these aliases if someone does change their user name, are they redirected though?

At first I liked this change, but now I think we better keep the UID. If D.O changes its pathauto settings to something different, then we would still get correct links at MAINTAINERS.txt.

Moreover, today the links work either if we use /u/mac_weber or /u/Mac_Weber, while the one provided by the system is the first one, I do prefer the second one as it reflects my real nickname better. If either one stops working in the future, then we would have to change this file again.

As we already have the nickname in this file, then I don't see a good reason for changing it now.

From @xjm at https://www.drupal.org/node/2491155#comment-9956299

it's somewhat embarrassing to have non-canonical links to our own website.

Then, I'm sending a rerolled patch.

@opdavies, there was too many changes on MAINTAINERS.txt

As I had to delete the file and upload it again before posting I think there was a problem when I really posted the reply.

Sending it again.

Yes, a redirect is automatically added. I just tested this on my D.o dev site with https://opdavies-drupal.redesign.devdrupal.org/u/opdavies (redirects to https://opdavies-drupal.redesign.devdrupal.org/u/opdavies2).

Devil's advocate: does d.o also prevent users from reusing *old* usernames of other users?

@Wim Leers if an user could reuse an old username from other user, then there would be people "reserving" usernames just to not allow others to use them. While it is really bad in case someone takes an old username form someone else to pretend to be this person, I also don't like the idea of someone withholding a bunch of nicknames for no good reason.

This can bring an interesting discussion, but a bit off topic for this particular issue =)

This is not a technical argument, but I like seeing the UIDs of different users. You can't easily see them on d.o anymore, but knowing how long someone has been on d.o (by relative lowness of UID) is always interesting.

So -0.5 from me :)

I guess this is nominally a patch for Dries as well. :)

Just a general note to the "what about renames?" objection... Note that if someone decides to rename themselves, the line needs to change either way, because it includes their username as well as their d.o URL.

As for the "what about potentially broken links?" objection... if a link goes dead (and sounds like it won't, according to #5), it's a simple one-line change to fix it. No big deal; more Novice patches for new contributors! :D

The objection in #15 still stands, though as a counter-point I've also seen people use UIDs as a means of showing off their "l33tness" and shunning "n00bs" (thankfully no one in MAINTAINERS.txt, but still), so in that respect putting everyone on equal footing could be seen as an improvement. :)

Committed to 8.x. Thanks!

Ah, I was hoping the reviewer of the D8 patch would review the D7 patch, but instead he *made* the D7 patch. ;) Thanks!

So I gave it a look. Mostly it looks fine, but it appears that several of the user names in the file are no longer correct (people had apparently changed their D.o user names since the last edit, which is not much of a surprise). I'm not sure if fixing these is in or out of scope for this issue, probably out of scope... so I think I'll go ahead and mark it RTBC and we can (if we want to) address the user names in a separate issue.

Here are my notes:

1. +++ b/MAINTAINERS.txt
   -- David Rothstein 'David_Rothstein' http://drupal.org/user/124982
   +- David Rothstein 'David_Rothstein' https://www.drupal.org/u/david_rothstein
   

   Interesting, I didn't realize the u/ aliases were case insensitive. I wonder if user names are also case insensitive? hm. Anyway, verified this is the correct URL for David.

2. +++ b/MAINTAINERS.txt
   +subsystems. See https://www.drupal.org/contribute/core-maintainers for more
   

   That page needs to be updated to point to the new Governance page, but that's a separate issue.

3. +++ b/MAINTAINERS.txt
   +- Damien Tournoud 'DamZ' https://www.drupal.org/u/damien-tournoud
   

   DamZ is not his user name any more apparently.

4. +++ b/MAINTAINERS.txt
   -- Gerhard Killesreiter 'killes' http://drupal.org/user/83
   +- Gerhard Killesreiter 'killes' https://www.drupal.org/u/gerhard-killesreiter
    
   

   Apparently 'killes' is also not his user name any more, at least for user/83. Now that's one ID that it's a shame to lose from this file.

5. +++ b/MAINTAINERS.txt
   -- Dave Reid 'davereid' http://drupal.org/user/53892
   +- Dave Reid 'davereid' https://www.drupal.org/u/dave-reid
   

   Here's another user name that changed.

Committed to 7.x - thanks!

Regarding #25, maybe some of those nicknames are like that deliberately if people want their IRC nicknames in there?

diff --git a/MAINTAINERS.txt b/MAINTAINERS.txt
index e970ded..28d1b3e 100644
--- a/MAINTAINERS.txt
+++ b/MAINTAINERS.txt
@@ -150,14 +150,14 @@ Node Access
 Security team
 -----------------
 
-To report a security issue, see: https://drupal.org/security-team/report-issue
+To report a security issue, see: https://www.drupal.org/security-team/report-issue
 
 The Drupal security team provides Security Advisories for vulnerabilities,
 assists developers in resolving security issues, and provides security
 documentation. See https://www.drupal.org/security-team for more information.
 The security team lead is:
 
-- Michael Hess 'mlhess' https://drupal.org/u/mlhess
+- Michael Hess 'mlhess' https://www.drupal.org/u/mlhess
 
 
 Module maintainers

Fixed on commit since those were the only two that still had the old URL format.