Problem/Motivation

According to #2346261: Deprecate entity_create() in favor of a <EntityType>::create($values) or \Drupal::entityManager()->getStorage($entity_type)->create($values), entity_create() function is going to be deprecated in favor of the create() method of the entity type class if known, or the EntityManager::create() helper.
That deprecated functions is used in a lot of different contextes.

Beta phase evaluation

Reference: https://www.drupal.org/core/beta-changes
Issue category Task
Issue priority Major because we do not want deprecated code in Core as it could be used as example
Prioritized changes The main goal of this issue is DX, performance and removing code already deprecated for 8.0.0. (Direct calls to EntityType::create are better than generic calls to entity_create for performances)
Disruption This change is not disruptive at all as it only replaces deprecated functions call by their exact equivalent.

Proposed resolution

Replace the deprecated call to entity_create() by a proper call to <EntityType>::create() or EntityManager::create(), according to the case, everywhere its needed.

Before:

entity_create('field_config', $field_values)->save();

$type = 'node';
entity_create($type, $node_values)->save();

After:

use Drupal\field\Entity\FieldConfig;
FieldConfig::create($field_values)->save();

use Drupal\Core\Entity\EntityManager;
$type = 'node';
EntityManager::create($type, $node_values)->save();

Remaining tasks

Contributor tasks needed
Task Novice task? Contributor instructions Complete?
Create a patch Instructions

User interface changes

None.

API changes

None.

Comments

duaelfr’s picture

Title: Replace deprecated usage of entity_create for field_config and field_storage_config in Field UI module » Replace deprecated usage of entity_create with a direct call to the entity type class in Field UI module
Issue summary: View changes

Update summary and title according to the change in the meta issue.

chananapeeyush’s picture

Assigned: Unassigned » chananapeeyush

Assigning myself

chananapeeyush’s picture

Status: Active » Needs review
StatusFileSize
new14.93 KB
chananapeeyush’s picture

StatusFileSize
new14.97 KB
new790 bytes

I found one typo myself.Love dreditor.

The last submitted patch, 3: 2491009-3.patch, failed testing.

duaelfr’s picture

Status: Needs review » Reviewed & tested by the community

Ok for me :)

catch’s picture

Status: Reviewed & tested by the community » Fixed

Committed/pushed to 8.0.x, thanks!

  • catch committed 35372e5 on 8.0.x
    Issue #2491009 by trwad: Replace deprecated usage of entity_create with...
duaelfr’s picture

@trwad Congratulations for your first Core commit attribution!

chananapeeyush’s picture

Thanks All!

duaelfr’s picture

Priority: Major » Normal

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.