move comment.theme.css to classy

Moving comment css file to classy

+++ b/core/themes/classy/classy.libraries.yml
@@ -3,3 +3,9 @@ base:
+comment-threaded:
+  version: VERSION
+  css:
+    theme:
+      css/comment/comment.theme.css: {}
\ No newline at end of file

We need a newline at the end of this file

We still need to remove the reference to the removed library here:

core/modules/comment/src/CommentViewBuilder.php:
  184        // Add indentation div or close open divs as needed.
  185        if ($build['#comment_threaded']) {
  186:         $build['#attached']['library'][] = 'comment/drupal.comment.threaded';
  187          $prefix .= $build['#comment_indent'] <= 0 ? str_repeat('</div>', abs($build['#comment_indent'])) : "\n" . '<div class="indented">';
  188        }

It also looks like we still have the indented classes here that should be in classy?

Done with the changes mentioned in #3. Please verify.

Nice, thanks. I think we need before/after screenshots of Classy.

Added novice tag.

Needs work for needs tag

CSS file is not calling in classy :(

Based on the discussion at #2489460: [Meta] Move module.theme.css files to Classy, at this point library names in Classy should match what is in the core module. So, comment-threaded should be drupal.comment.threaded.

I tested thread comments in both Stark and Classy and I can confirm that the comments indent in Classy but no longer indent in Stark. Thanks!

Stark:

Classy:

Bartik overrides comment.html.twig so comment.theme.css won't be attached for Bartik.

@mortendk seems fine here. I cleared caches and made a comment on a node and viewed that node:

Would be nice to only attach when threaded though, that's what the logic before was doing…

Implemented #17.

The is a non disruptive CSS change. Committed ae86ffd and pushed to 8.0.x. Thanks!

Can the meta issue have the proper beta evaluation added - thanks.

Evaluation added.