Problem/Motivation

We should reduce the amount of "special patterns" that only applies to Views.

Proposed resolution

Improve specificity on a line of CSS on views dropdown button.

before patch List Views

The edit button font size was 10px, because a css rule from views-ui was affecting this button.
before edit button

before patch Views UI

The add button font size was 10px, this is correct, needs to stay after patch.
before

after patch List Views

css rule no longer applies to the "edit" button on this page because css rule was made more specific.
after

after patch Views UI

css rule is now more specific to apply to the buttons on this page only.
after

Remaining tasks

  • Patch created - done
  • Community tested - done
  • Beta evaluation - done
  • Screenshots - done

User interface changes

Dropbutton font size increase on the views listing page.

API changes

None

Beta phase evaluation

Reference: https://www.drupal.org/core/beta-changes
Issue category Task because issue cleans up CSS code
Issue priority Normal because CSS change is isolated to specific Views user interface.
Unfrozen changes Unfrozen because it only changes CSS

Comments

lewisnyman’s picture

shellshocked59’s picture

Status: Active » Needs review
StatusFileSize
new593 bytes

I changed the CSS from
.js .dropbutton-wrapper .dropbutton .dropbutton-action > * {
to
.js #view-edit-form .dropbutton-wrapper .dropbutton .dropbutton-action > * {

Bojhan’s picture

Status: Needs review » Reviewed & tested by the community

Looks good, tested it and only effected what we needed.

lewisnyman’s picture

Status: Reviewed & tested by the community » Needs work
+++ b/core/modules/views_ui/css/views_ui.admin.theme.css
@@ -1148,7 +1148,7 @@ div.messages {
-.js .dropbutton-wrapper .dropbutton .dropbutton-action > * {
+.js #view-edit-form .dropbutton-wrapper .dropbutton .dropbutton-action > * {

Sorry, can we use a class instead of an ID?

shellshocked59’s picture

Sure, here it is using .views-edit-view instead

shellshocked59’s picture

Status: Needs work » Needs review
AllieRays’s picture

Assigned: Unassigned » AllieRays

patch working as expected. =)

AllieRays’s picture

Assigned: AllieRays » Unassigned
Status: Needs review » Active
AllieRays’s picture

Status: Active » Needs review
davidneedham’s picture

Status: Needs review » Reviewed & tested by the community

Look good to me.

mradcliffe’s picture

It would really be nice to have some screenshots, and we need to do a beta evaluation for this normal task.

bpleduc’s picture

Issue tags: -Needs screenshots
StatusFileSize
new329.28 KB

I have tested this and found that it applied in the Views UI. Not sure this was the desired location as it was stated above "(not Views UI itself)".

Screen shot attached.

bpleduc’s picture

Status: Reviewed & tested by the community » Needs review
alimac’s picture

bpleduc, is that a before or after screenshot? Can you add the before/after screenshot?

AllieRays’s picture

Issue summary: View changes
StatusFileSize
new594.7 KB
mradcliffe’s picture

That's great, @devuable. Could you submit as 2 different screenshots? I found it a bit confusing as one image.

AllieRays’s picture

Issue summary: View changes
StatusFileSize
new188.67 KB
new407.5 KB
AllieRays’s picture

Issue summary: View changes
bpleduc’s picture

I will be reviewing before and after screen shots and cleaning up attached files.

bpleduc’s picture

jdcosta’s picture

Issue summary: View changes
Issue tags: -Needs beta evaluation

Added beta evaluation

mradcliffe’s picture

@jdcosta, I think this issue is more about user experience than usability - re: beta evaluation

jdcosta’s picture

It is user usability experience

alimac’s picture

Issue tags: +LIVE commit candidate
alimac’s picture

Issue summary: View changes
lewisnyman’s picture

Status: Needs review » Reviewed & tested by the community

Thanks for adding the screenshots. This looks good.

shellshocked59’s picture

Issue summary: View changes
shellshocked59’s picture

Issue summary: View changes
shellshocked59’s picture

Issue summary: View changes
shellshocked59’s picture

Issue summary: View changes
AllieRays’s picture

StatusFileSize
new296.72 KB
new296.54 KB
new368.59 KB
new249.58 KB
AllieRays’s picture

Issue summary: View changes
AllieRays’s picture

Issue summary: View changes
AllieRays’s picture

Issue summary: View changes
AllieRays’s picture

Issue summary: View changes
mradcliffe’s picture

Issue summary: View changes

Improved beta evaluation.

mradcliffe’s picture

Issue summary: View changes

I changed the priority row of the beta evaluation because it did not accurately reflect the Priority levels of issues page based on the first part of the Normal section instead of just looking at the Normal Tasks sub-section.

yesct’s picture

Issue tags: -LIVE commit candidate
xjm’s picture

yesct’s picture

Issue summary: View changes

opps. one of the screenshots was the wrong file name. fixed it to show the edit button before screenshot.

alexpott’s picture

Status: Reviewed & tested by the community » Fixed

Committed e9a25fc and pushed to 8.0.x. Thanks!

Thanks for adding the beta evaluation.

  • alexpott committed e9a25fc on 8.0.x
    Issue #2489362 by shellshocked59, devupable, bpleduc, LewisNyman: Change...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.