Found in #2486177-94: Deleting an entity translation from the UI deletes the whole entity.

Problem/Motivation

Contextual links do not take language into account, thus they stored in the client's local storage once and for all regardless of the site language and possibly the target content language.

Proposed resolution

Always pass the URL language as metadata to build language-aware ids.

Remaining tasks

  • Validate the solution
  • Write a patch
  • Review it

User interface changes

None

API changes

None

CommentFileSizeAuthor
#8 contextual-multilingual-2488940-8.patch10.89 KBplach
#8 contextual-multilingual-2488940-8.interdiff.txt1.6 KBplach
#5 contextual-multilingual-2488940-5.patch10.12 KBplach
#2 contextual-multilingual-2488940-2.patch8.16 KBplach
#2 contextual-multilingual-2488940-2-test.patch5.8 KBplach

Comments

plach’s picture

plach
he/him
Primary language Italian
Location Venezia
commented
Title: Contextual links broken on multilingual sites » Contextual links are broken on multilingual sites
Assigned: Unassigned » plach
Related issues: +#2486177: Deleting an entity translation from the UI deletes the whole entity

Working on this

plach’s picture

plach
he/him
Primary language Italian
Location Venezia
commented
Assigned: plach » Unassigned
Status: Active » Needs review
StatusFileSize
new contextual-multilingual-2488940-2-test.patch5.8 KB
new contextual-multilingual-2488940-2.patch8.16 KB

Let's try this

The last submitted patch, 2: contextual-multilingual-2488940-2-test.patch, failed testing.

Status: Needs review » Needs work

The last submitted patch, 2: contextual-multilingual-2488940-2.patch, failed testing.

plach’s picture

plach
he/him
Primary language Italian
Location Venezia
commented
Status: Needs work » Needs review
StatusFileSize
new contextual-multilingual-2488940-5.patch10.12 KB

This should be better

plach’s picture

plach
he/him
Primary language Italian
Location Venezia
commented
Issue summary: View changes
dawehner’s picture

dawehner
Primary language German
commented 
+++ b/core/modules/contextual/contextual.module
@@ -155,9 +156,14 @@ function contextual_contextual_links_view_alter(&$element, $items) {
+    if (!isset($args['metadata'])) {
+      $args['metadata'] = [];
+    }
+    $args['metadata'] += ['langcode' => $langcode];

What about using $args += ['metadata' => []]; and $args['metadata'] += ['langcode' => $langcode];

plach’s picture

plach
he/him
Primary language Italian
Location Venezia
commented
StatusFileSize
new contextual-multilingual-2488940-8.interdiff.txt1.6 KB
new contextual-multilingual-2488940-8.patch10.89 KB

Addressed #7

dawehner’s picture

dawehner
Primary language German
commented
Status: Needs review » Reviewed & tested by the community

This looks perfect for me

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

This issue addresses a major bug and is allowed per https://www.drupal.org/core/beta-changes. Committed 0b1a9a3 and pushed to 8.0.x. Thanks!

  • alexpott committed 0b1a9a3 on 8.0.x 
    Issue #2488940 by plach: Contextual links are broken on multilingual...
gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Issue tags: -sprint

Yay, thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.