Problem/Motivation

Bartik doesn't set CSS files under the right libraries.

Proposed resolution

Set Bartik CSS files under the right libraries

Remaining tasks

-Write fix
-Take screenshots

User interface changes

-

API changes

-

CommentFileSizeAuthor
#5 Bartik-library-restructure.pdf12.58 MBemma.maria
#4 bartik_css_library-2488936-4.patch894 byteslauriii
#1 bartik_css_library-2488936-1.patch2.64 KBlauriii
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
CreditAttribution: lauriii as a volunteer and at Druid commented
Status: Active » Needs review
FileSize
bartik_css_library-2488936-1.patch2.64 KB

Status: Needs review » Needs work

The last submitted patch, 1: bartik_css_library-2488936-1.patch, failed testing.

The last submitted patch, 1: bartik_css_library-2488936-1.patch, failed testing.

lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
CreditAttribution: lauriii as a volunteer and at Druid commented
Status: Needs work » Needs review
FileSize
bartik_css_library-2488936-4.patch894 bytes
emma.maria’s picture

emma.maria
she/her
CreditAttribution: emma.maria commented
Issue tags: +frontend
FileSize
Bartik-library-restructure.pdf12.58 MB

I agree with the work in #4 it follows the same pattern as Seven. Plus I ran 15 visual tests with real content to check nothing is broken. Can someone else double check the code and set this to RTBC just incase I missed something?

LewisNyman’s picture

LewisNyman
he/him
CreditAttribution: LewisNyman at Wunder commented
Status: Needs review » Reviewed & tested by the community
Issue tags: +CSS

These all fit within my understanding of the SMACSS definitions.

Wim Leers’s picture

Wim Leers
Location Ghent 🇧🇪🇪🇺
CreditAttribution: Wim Leers at Acquia commented
Issue tags: +TX (Themer Experience), +DX (Developer Experience)

+1

Wim Leers’s picture

Wim Leers
Location Ghent 🇧🇪🇪🇺
CreditAttribution: Wim Leers at Acquia commented

#5: WOW!!!!!!! How did you do that?

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Chapter Three commented
Status: Reviewed & tested by the community » Fixed

This is a CSS only change therefore permitted during beta. Committed 08d4176 and pushed to 8.0.x. Thanks!

  • alexpott committed 08d4176 on 8.0.x 
    Issue #2488936 by lauriii, emma.maria: Bartik CSS library reordering

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.