Hi,
I'm not sure if this is a bug, but here it is:

After disabling the module, I go to /admin/build/modules/uninstall and there is no option to unistall Javascript Aggregator.

Is this how it's supposed to be?
Won't there be dorman tables left-over in case people want to disable and delete this module?

Comments

derjochenmeyer’s picture

derjochenmeyer CreditAttribution: derjochenmeyer commented
Status: Active » Closed (won't fix)

HI drupalin, there are no tables created by this module... many drupal modules dont have an uninstall option...

Island Usurper’s picture

Island Usurper CreditAttribution: Island Usurper commented
Status: Closed (won't fix) » Active

However, there are still variables left in the variable table. Even worse, these are all loaded into memory from the cache whether they are needed or not. Only modules that don't have any configuration options don't need an uninstall function.

Island Usurper’s picture

Island Usurper CreditAttribution: Island Usurper commented
Priority: Normal » Minor
RobLoach’s picture

RobLoach
he/him
CreditAttribution: RobLoach commented
Status: Active » Fixed

http://drupal.org/cvs?commit=149735

The newly added hook_uninstall in javascript_aggregator.install clears the cached JavaScript as well as deletes the variables.

Anonymous’s picture

Anonymous (not verified) CreditAttribution: Anonymous commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.

derjochenmeyer’s picture

derjochenmeyer CreditAttribution: derjochenmeyer commented
Version: 5.x-1.3 » 6.x-1.x-dev
Assigned: Unassigned » derjochenmeyer
Priority: Minor » Normal
Status: Closed (fixed) » Needs review 
/**
 * Implementation of hook_uninstall().
 */
function javascript_aggregator_uninstall() {
  $htaccess = file_directory_path() . '/js/.htaccess';
  file_delete($htaccess);

  variable_del('javascript_aggregator_gzip');
  variable_del('javascript_aggregator_no_htaccess');
  variable_del('javascript_aggregator_jsminplus');
}

It seems the uninstall didnt delete the htaccess file. This code above fixes it. I'll rework this into a patch later and commit it to dev.

derjochenmeyer’s picture

derjochenmeyer CreditAttribution: derjochenmeyer commented
Title: No option to Uninstall » Make sure all variables and .htaccess file get deleted on uninstall

Better title.

derjochenmeyer’s picture

derjochenmeyer CreditAttribution: derjochenmeyer commented
Status: Needs review » Fixed

Committed to 6.x-1.x-dev

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.