Eslint updated their config, deprecated an option we were using for checking function name spacing.

Here is the right config, and there are 2 errors to fix: 

theodore@monkey:~/DEV/DRUPAL/drupal$ eslint .

core/misc/dialog/dialog.ajax.js
  45:38  error  Missing space before function parentheses  space-before-function-paren

core/modules/tour/js/tour.js
  26:42  error  Missing space before function parentheses  space-before-function-paren

✖ 2 problems (2 errors, 0 warnings)
CommentFileSizeAuthor
#1 2487261-eslint-1.patch1.61 KBalanburke
core-js-eslint-function-spaceing.patch604 bytesnod_

Comments

alanburke’s picture

alanburke commented
Status: Needs work » Needs review
StatusFileSize
new 2487261-eslint-1.patch1.61 KB
nod_’s picture

nod_
Primary language French
Location Lille
commented
Status: Needs review » Reviewed & tested by the community

Perfect, thanks :)

  • xjm committed 0c50be4 on 8.0.x 
    Issue #2487261 by nod_, alanburke: Eslint config update for function...
xjm’s picture

xjm
she/her
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Although it's a coding standards change, I think this change makes sense during the beta since it's keeping our third-party tools future-compatible. Committed and pushed to 8.0.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.