Current version: 2.3.0
New version: 2.3.1

https://github.com/scottjehl/picturefill

CommentFileSizeAuthor
#4 Update_JS_library_picturefill_to_2.3.1-2485579-4.patch15.83 KBram4nd

Comments

nod_’s picture

nod_
Primary language French
Location Lille
commented
Issue tags: +Novice, +JavaScript
ram4nd’s picture

ram4nd commented
Assigned: Unassigned » ram4nd
ram4nd’s picture

ram4nd commented
Title: Update picturefill to 2.3.1 » Update JS library picturefill to 2.3.1
Status: Active » Needs work
ram4nd’s picture

ram4nd commented
Assigned: ram4nd » Unassigned
Status: Needs work » Needs review
StatusFileSize
new Update_JS_library_picturefill_to_2.3.1-2485579-4.patch15.83 KB
evilfurryone’s picture

evilfurryone commented

I was able to verify that the JS library has updated, but I was not able to actually test it as I did not find a place or situation where it is used. Can someone either test functionality or point in the proper direction where I can take a look.

imiksu’s picture

imiksu
Location Finland
commented

The patch itself looks ok to me. Not sure myself either how to test picturefill JS functionality.

droplet’s picture

droplet commented
Status: Needs review » Reviewed & tested by the community

Basically this version added currentSrc supports but it didn't use in Drupal. (https://github.com/scottjehl/picturefill/issues/478)

Looks good to me.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed to 8.0.x. Thanks!

  • webchick committed 8cb29f9 on 8.0.x 
    Issue #2485579 by ram4nd, droplet, nod_, MustangGB, evilfurryone, iMiksu...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.