Closed (fixed)
Project:
Drupal core
Version:
8.0.x-dev
Component:
javascript
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
8 May 2015 at 13:45 UTC
Updated:
25 May 2015 at 20:04 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
nod_When updating include the minified file, the original source and the source map file (if any supplied by the lib).
Comment #2
alanburke commentedUpdated to new version, and source file added.
Comment #4
imiksuWe need to update the tests too at\Drupal\system\Tests\Common\AttachedAssetsTest::testVersionQueryStringEDIT: I figured out that it was actually changed, investigating now why failing.
Comment #5
imiksuComment #6
imiksuWe need to update the
core.libraries.ymlfile. I haven't worked with external JS libraries before, so I'm not sure do we need to provide the source file by executing something?Comment #7
ragnarkurm commentedComment #8
nikita.izotov commentedTested, everything is ok
how i tested it manually:
Comment #9
alexpott@nod_ given that the minified is not minified should we be bothering to in the unminified file.
Comment #10
nod_Umm yeah, let's loose the unminified file for that one. I don't want to add the unminified version of modernizr or ckeditor or any other lib we don't have a map file for.
Comment #11
alanburke commentedComment #12
nod_Thanks, all good.
Nice reduction in size with their new minification config.
Comment #13
wim leersWow, yes, significantly smaller!
Comment #14
alexpottCommitted 9489b81 and pushed to 8.0.x. Thanks!