Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Problem/Motivation
See: #1995272: [Meta] Refactor module CSS files inline with our CSS standards
Proposed resolution
Review the CSS against our standards, see:
http://drupal.org/node/1887918#best-practices
https://www.drupal.org/node/2408617
#1190252: [573] Use csslint as a weapon to beat the crappy CSS out of Drupal core
Remaining tasks
Review current CSS
Write a patch to fix the suggestions
Run CSSlint against the new CSS
Testing steps
You have to enable the core-language modules
Add a language
Go to admin/config/regional/content-language
User interface changes
None
API changes
None
Comment | File | Size | Author |
---|---|---|---|
#11 | rtl-after-content-translation.png | 68.55 KB | Manjit.Singh |
#11 | rtl-before-content-translation.png | 69.83 KB | Manjit.Singh |
#10 | After.png | 22.73 KB | rudraram |
#10 | Before.png | 23.72 KB | rudraram |
#7 | interdiff-2485409-4-7.txt | 1.54 KB | Manjit.Singh |
Comments
Comment #1
LewisNymanComment #2
LewisNymanComment #3
rudraram CreditAttribution: rudraram at Axelerant commentedAdded class to the form and updated css.
Comment #4
rudraram CreditAttribution: rudraram at Axelerant commentedThe above patch was wrong. Updated it.
Comment #6
LewisNymanCan we remove the table element from these selectors?
Comment #7
Manjit.Singhremoving table element as suggested by @lewis
Comment #8
Manjit.SinghComment #9
LewisNymanGreat, now we just need some before/after screenshots
Comment #10
rudraram CreditAttribution: rudraram at Axelerant commentedAdding screenshots
Before:
After:
Comment #11
Manjit.Singhuploaded
rtl
screenshots as well ;)seems like no regression issues.. :) changing status to RTBC.
Comment #14
lauriiiComment #15
LewisNymanBack to RTBC
Comment #16
alexpottIsn't there a patch somewhere to change this to use the standard admin layout classes?
Comment #17
LewisNyman@alexpott These width properties are for table cells instead of regular elements so we can't apply the reuseable classes to them. I'm not sure how we can make this CSS more generic, so for now the best we can do it remove the CSSLint errors.
Comment #18
alexpottCommitted 880007d and pushed to 8.0.x. Thanks!
CSS is not frozen in beta.