The filter hardcodes "node" as alias in three places instead of fetching the filter handler's table alias. This causes invalid queries when the filter is used with a relationship and the base table is not node.

CommentFileSizeAuthor
#5 select_translation-do-not-hardcode-table-alias-2485045-5.patch2.09 KBao2
#1 select_translation-hardcoded_alias-2485045-1.patch1.23 KBciss

Comments

ciss’s picture

ciss commented
Status: Active » Needs review
StatusFileSize
new select_translation-hardcoded_alias-2485045-1.patch1.23 KB
sdelbosc’s picture

sdelbosc commented

I agree with ciss. The module does not handle the views with relationships properly as the join is not done on the related table but always node table.
The patch provided works fine for me.

nironan’s picture

nironan commented
Status: Needs review » Reviewed & tested by the community

Works fine on our production environment.

ao2’s picture

ao2 commented
Version: 7.x-1.x-dev » 8.x-1.x-dev
Status: Reviewed & tested by the community » Needs work

If there is still interest in this, please consider sending a patch for the drupal 8 version of the module.

Thanks,
Antonio

ao2’s picture

ao2 commented
Status: Needs work » Needs review
StatusFileSize
new select_translation-do-not-hardcode-table-alias-2485045-5.patch2.09 KB

Attaching an updated patch for the drupal 8 version of the module.

I am not pushing this directly because I did not experience the original problem, so I am waiting for a review or a test.

Thanks,
Antonio

ao2’s picture

ao2 commented

Can anyone suggest how to set up a test case for this patch?

Thank you,
Antonio

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented

@sdelbosc and @ciss could you please review and test the patch in #5?

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Version: 8.x-1.x-dev » 2.x-dev
anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Status: Needs review » Fixed

Committed to 2.x!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.