Problem/Motivation

Just prefer closing modals with the escape key.

Proposed resolution

Capture the keydown event and close the modal.

Remaining tasks

User interface changes

API changes

CommentFileSizeAuthor
#8 close_overlay_with-2484439-8.patch875 bytesjoelpittet
#8 interdiff.txt827 bytesjoelpittet
#6 close_overlay_with-2484439-6.patch832 bytesjoelpittet
#1 close_overlay_with-2484439-1.patch814 bytesjoelpittet

Comments

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
StatusFileSize
new close_overlay_with-2484439-1.patch814 bytes

Here's a patch with that working.

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
Status: Active » Needs review
subhojit777’s picture

subhojit777
he/him
Primary language Bengali
commented

Thanks for the patch :) I was also thinking about the same.

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented

Does it work for you?

subhojit777’s picture

subhojit777
he/him
Primary language Bengali
commented

I have not tested the code yet. Will do it soon. Thanks!

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
StatusFileSize
new close_overlay_with-2484439-6.patch832 bytes

re-roll with latest dev changes.

subhojit777’s picture

subhojit777
he/him
Primary language Bengali
commented

Thank you :) Just a small change.

+++ b/js/dc_ajax_add_cart.js
@@ -1,9 +1,16 @@
+      function closeAddToCartOverlay() {

Can you please add a function description here.

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
StatusFileSize
new interdiff.txt827 bytes
new close_overlay_with-2484439-8.patch875 bytes

Feel free to write what you want for the comment.

subhojit777’s picture

subhojit777
he/him
Primary language Bengali
commented
Status: Needs review » Fixed

Committed, thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.