Problem/Motivation

The class has the wrong @file declaration, doesn't alphabetize its import statements, uses lowerCamelCase for local variables, and has extraneous inline @var typehints.

Proposed resolution

Fix

Remaining tasks

None

User interface changes

None

API changes

None

CommentFileSizeAuthor
#1 2484247-1.patch2.42 KBtim.plunkett

Comments

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Status: Active » Needs review
StatusFileSize
new 2484247-1.patch2.42 KB

I was looking through this class while discussing #2263569: Bypass form caching by default for forms using #ajax. with @effulgentsia, and the little oddities just got to me :)

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Priority: Normal » Minor
Status: Needs review » Reviewed & tested by the community
Issue tags: +Trivial patch of the month
xjm’s picture

xjm
she/her
Primary language English
commented
Category: Task » Bug report
Status: Reviewed & tested by the community » Fixed

So, as a rule, the use statement alphabetizing and de-camel-casing isn't really something we should be doing during beta, but since the incorrect docs are a bug and the other changes are tiny and without any disruption, I'm going to go ahead and commit this patch. In general, we should ensure that any changes in the patch are covered under the allowed beta changes, particularly for normal and minor issues.

Committed and pushed to 8.0.x. Thanks @Wim Leers and @tim.plunkett!

  • xjm committed 608f81b on 8.0.x 
    Issue #2484247 by tim.plunkett: Documentation and coding standards fixes...
xjm’s picture

xjm
she/her
Primary language English
commented
Title: Coding standards fixes for \Drupal\system\Controller\FormAjaxController » Documentation and coding standards fixes for \Drupal\system\Controller\FormAjaxController

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.