Range exposed filters are displayed without label/description [#2483905]

Problem/Motivation

To reproduce:

Edit "Content" view
Add a filter on "Authored on" field
Expose it
Select "is between" operator
Save view

Expected behaviour:
Newly created filter is displayed with a label and two text-fields that allow user to define range to filter on.

Actual behaviour
The two text-fields are displayed without label.

This bug is specially annoying when you have more than one such filter as it is very hard to distinguish between them.

D7 handles this on a template level, which was removed in D8.

#2455961: Exposed filter of Changed displays with label of Operator is most likely result of the same problem.

Proposed resolution

I see two potential solutions for this problem:

Re-introduce template for views_exposed_form (which will also fix #2455961: Exposed filter of Changed displays with label of Operator)
Make sure label appears in exposed form render array in a correct form

Remaining tasks

- agree on approach
- write patch
- write test

User interface changes

- labels are correctly displayed with exposed filters

API changes

n/a

Comment	File	Size	Author
#9	2483905.JPG	30.89 KB	chandru225
#5	2483905_5_TEST_ONLY.patch	1.86 KB	slashrsm
#5	2483905_5.patch	2.58 KB	slashrsm
#3	only_title.png	60.36 KB	slashrsm
#3	fieldset.png	68.26 KB	slashrsm
#3	current.png	59.31 KB	slashrsm
#3	2483905_1_title.patch	738 bytes	slashrsm
#3	2483905_1_fieldset.patch	622 bytes	slashrsm

Comments

Comment #1

slashrsm commented 6 May 2015 at 12:29

Issue summary:

View changes

Comment #2

dawehner

German

commented 23 June 2015 at 12:06

Mh, that template was always really confusing for the themer, it would be great to avoid that, if possible.

Make sure label appears in exposed form render array in a correct form

That seems to be the better solution I think. I guess we "just" need to tweak the labels which are defined in core/modules/views/src/Plugin/views/filter/NumericFilter.php:206?

Comment #3

slashrsm commented 23 June 2015 at 14:22

Issue summary:	View changes
Status:	Active	» Needs review

Status	File	Size
new	2483905_1_fieldset.patch	622 bytes
new	2483905_1_title.patch	738 bytes
new	current.png	59.31 KB
new	fieldset.png	68.26 KB
new	only_title.png	60.36 KB

This is how range exposed filters look at the moment:

I think we have two possible solutions for this issue:

We make sure title is properly displayed above first form element. This is how D7 Views are done. 2483905_1_title.patch implements this approach.
We could also wrap everything in a fieldset. This would also be useful in cases where we expose operator too. This approach changes general look and feel of exposed filters. 2483905_1_fieldset.patch implements this approach.

Comment #4

slashrsm commented 23 June 2015 at 15:04

Discussed this on IRC with @dawehner and we both agreed first option is probably the way to go. Would be nice to get some feedback from @bojhan about grouping of filters though.