It would be great to fix maximum of the following issues for 7.x-3.x:
http://pareview.sh/pareview/httpgitdrupalorgprojectyandexmetricsgit-7x-3x

CommentFileSizeAuthor
#6 yandex_metrics-follow_drupal_standards-2481957.patch43.81 KBfortis
#4 yandex_metrics-code_style_fixes_part_1-Issue_2481957.patch6.62 KBfortis
#3 yandex_metrics-code_style_fixes_part_1-Issue_2481957.patch0 bytesfortis

Comments

Konstantin Komelin’s picture

Konstantin Komelin commented
Issue summary: View changes
fortis’s picture

fortis commented
Assigned: Unassigned » fortis

okay, i'll try to help

fortis’s picture

fortis commented
StatusFileSize
new yandex_metrics-code_style_fixes_part_1-Issue_2481957.patch0 bytes

this is the first part of hotfixes

fortis’s picture

fortis commented
StatusFileSize
new yandex_metrics-code_style_fixes_part_1-Issue_2481957.patch6.62 KB
Konstantin Komelin’s picture

Konstantin Komelin commented

Hi @fortis,

Thanks for your patches. We can't accept partial fixes. Please provide a patch with fixes for all issues at once.
Then change the issue status to Needs review.

Thanks,
Konstantin

fortis’s picture

fortis commented
Status: Needs work » Needs review
StatusFileSize
new yandex_metrics-follow_drupal_standards-2481957.patch43.81 KB

okay, attached patch that fix all problems.

this is phpcs log after fixing

imacoda$ phpcs --standard=Drupal ~/Work/PhpstormProjects/yandex_metrics/ -v

Registering sniffs in the Drupal standard... DONE (96 sniffs registered)
Creating file list... DONE (4 files in queue)
Changing into directory /Users/imacoda/Work/PhpstormProjects/yandex_metrics/css
Processing yandex_metrics.css [CSS => 16 tokens in 4 lines]... DONE in 3ms (0 errors, 0 warnings)
Changing into directory /Users/imacoda/Work/PhpstormProjects/yandex_metrics
Processing yandex_metrics.variable.inc [PHP => 678 tokens in 87 lines]... DONE in 19ms (0 errors, 0 warnings)
Changing into directory /Users/imacoda/Work/PhpstormProjects/yandex_metrics/yandex_metrics_reports/css
Processing yandex_metrics_reports.css [CSS => 68 tokens in 14 lines]... DONE in 2ms (0 errors, 0 warnings)
Changing into directory /Users/imacoda/Work/PhpstormProjects/yandex_metrics/yandex_metrics_reports
Processing yandex_metrics_reports.reports.inc [PHP => 3353 tokens in 461 lines]... DONE in 127ms (0 errors, 0 warnings)
fortis’s picture

fortis commented

hi, do you have some problems with patch? need some help?

  • kalabro committed f8516f9 on 7.x-3.x authored by fortis 
    Issue #2481957 by fortis: Fix code style issues
kalabro’s picture

kalabro
she/her
commented
Status: Needs review » Fixed

It should be fine. Committed. Thanks @fortis!

Konstantin Komelin’s picture

Konstantin Komelin commented

Thanks @fortis and @kalabro. Good job.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.