Closed (fixed)
Project:
Drupal core
Version:
8.0.x-dev
Component:
postgresql db driver
Priority:
Major
Category:
Bug report
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
30 Apr 2015 at 16:10 UTC
Updated:
28 May 2015 at 20:54 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
dawehnerWell, in that case I'd always suggest to add the most minimal order, which is NID almost ever ...
Comment #2
mradcliffeComment #3
mradcliffePasses SQLite on my local environment.
Comment #4
dawehnerIt seems to be for me that the easiest way to fix that would be to replace the created one with sorting by
field_views_testing_group_?Comment #5
jaredsmith commentedI can confirm that this patch indeed fixes the failing test in Drupal\views\Tests\Handler\FieldGroupRowsWebTest. I've also reviewed the patch manually, and while I don't pretend to understand everything, it looks quite straightforward. Marking as RTBC.
Before the patch:
Drupal\views\Tests\Handler\FieldGroupRowsWebTest 9 passes 1 fails
After the patch:
Drupal\views\Tests\Handler\FieldGroupRowsWebTest 10 passes
Comment #6
webchickDoesn't look like #4 has been addressed.
Comment #7
mradcliffeI wasn't able to generate an interdiff with this patch. Since this changed the sort, we need to run through tests again.
Comment #8
mradcliffeI was running views test group thru drupalci, but drupalci just stopped halfway. The two tests passed though.
Drupal\views\Tests\Handler\FieldGroupRowsTest 6 passes
Drupal\views\Tests\Handler\FieldGroupRowsWebTest 10 passes
Comment #9
jaredsmith commentedI have reviewed the code in the patch again, as well as tested it again using the new DrupalCI infrastructure.
Before the patch:
Drupal\views\Tests\Handler\FieldGroupRowsWebTest 9 passes 1 fails
After the patch:
Drupal\views\Tests\Handler\FieldGroupRowsWebTest 10 passes
Additionally, it causes no other regressions in the views test suite. As such, I'm setting this back to RTBC.
Comment #10
webchickCommitted and pushed to 8.0.x. Thanks!