I was testing feedapi on -r DRUPAL-6, and got these notices:
notice: Undefined index: type in /home/balu/projects/drupal/6/planetsoc/sites/all/modules/feedapi/feedapi.module on line 474.
Even more weird error jumps up when I hit node/add/feedapi-node:
* notice: Undefined index: type in /home/balu/projects/drupal/6/planetsoc/sites/all/modules/feedapi/feedapi.module on line 474.
* notice: Undefined property: stdClass::$feedapi_node in /home/balu/projects/drupal/6/planetsoc/sites/all/modules/feedapi/feedapi_inherit/feedapi_inherit.module on line 33.
* notice: Trying to get property of non-object in /home/balu/projects/drupal/6/planetsoc/sites/all/modules/feedapi/feedapi_inherit/feedapi_inherit.module on line 33.
* notice: Undefined index: values in /home/balu/projects/drupal/6/planetsoc/sites/all/modules/feedapi/feedapi.module on line 486.
* notice: Undefined property: stdClass::$feed in /home/balu/projects/drupal/6/planetsoc/sites/all/modules/feedapi/feedapi.module on line 489.
* notice: Trying to get property of non-object in /home/balu/projects/drupal/6/planetsoc/sites/all/modules/feedapi/feedapi.module on line 489.
* notice: Undefined index: values in /home/balu/projects/drupal/6/planetsoc/sites/all/modules/feedapi/feedapi.module on line 492.
* notice: Undefined variable: feedapi_url_default in /home/balu/projects/drupal/6/planetsoc/sites/all/modules/feedapi/feedapi.module on line 499.
* notice: Undefined variable: form in /home/balu/projects/drupal/6/planetsoc/sites/all/modules/feedapi/feedapi_inherit/feedapi_inherit.module on line 77.
* notice: Undefined variable: form in /home/balu/projects/drupal/6/planetsoc/sites/all/modules/feedapi/feedapi_node/feedapi_node.module on line 147.
* notice: Undefined index: parser_common_syndication in /home/balu/projects/drupal/6/planetsoc/sites/all/modules/feedapi/feedapi.module on line 519.
* notice: Undefined property: stdClass::$nid in /home/balu/projects/drupal/6/planetsoc/sites/all/modules/feedapi/feedapi.module on line 543.
| Comment | File | Size | Author |
|---|---|---|---|
| #13 | feedapi_stat.patch | 691 bytes | mustafau |
| #7 | feedapi-fix-notices.patch | 15.89 KB | mustafau |
| #6 | feedapi-fix-notices.patch | 8.12 KB | mustafau |
| #4 | feedapi-fix-notices.patch | 6.27 KB | mustafau |
| #2 | feedapi-fix-notices-248042-2.patch | 6.01 KB | webchick |
Comments
Comment #1
mustafau commentedI have created a patch to fix these error.
Comment #2
webchickI still get:
...when first installing the FeedAPI Node module.
This patch is the same as above, but also fixes these notices.
Comment #3
webchickUgh. No, there are still a bunch...
On fresh node creation:
after you fix that one:
after you fix that one:
:(
This is going to take too much time for me to look into atm.
Comment #4
mustafau commentedThis patch seems to fix all of those notices.
Comment #5
mustafau commentedFollowing notices are remaining:
Comment #6
mustafau commentedFollowing notices are shown on non FeedAPI-enabled node form. Updated patch fixing these notices is attached.
Comment #7
mustafau commentedI found following notices:
Updated patch fixing all but following is attached.
Comment #8
aron novakThanks a lot to all of you to providing the patches! (while i was struggling at the university, FeedAPI become better continuously :D )
But I'm curious why these messages appear. I have never seen those messages and even more important:
http://php.net/manual/en/function.error-reporting.php
So by default, notices are not displayed. Do all of you use non-default value? Is there such a module which alters this default behavior?
Comment #9
webchick^ E_NOTICE is only added for releases of Drupal. Dev tarballs and CVS checkouts (-r DRUPAL-6) report E_ALL.
Comment #10
aron novakAhha, i always use official releases. This explains everything. :)
Anyway, the patch is fixed and i also killed some possible notice-source.
Please reopen if a notice appears and give the number of the line and the revision of the code.
Comment #11
mustafau commentedFollowing notices are remaining:
Comment #12
mustafau commentedMore notices:
Comment #13
mustafau commentedFollowing notice is shown when there is no entry in the stats table:
notice: Undefined variable: stat in feedapi.module on line 1523.Fix is attached.
Comment #14
mustafau commentedEven more:
Comment #15
aron novakI fixed all of the above notices.
Comment #16
Anonymous (not verified) commentedAutomatically closed -- issue fixed for two weeks with no activity.