The 2026 Drupal Business Survey is open. Your response will help shape the future of the Drupal business ecosystem.Discovered over in #2477337: Saving a menu item with internal path instead of entity reference loses hierarchy. The tests within doTestMenuHierarchy have not been getting run since #2104123: Consolidate test methods in MenuRouterTest.
| Comment | File | Size | Author |
|---|---|---|---|
| #3 | menu-hierarchy-tests-2479819-03.patch | 1.73 KB | jhedstrom |
Comments
Comment #1
jhedstromThis gets all tests passing but one, and I'm not immediately clear if the failing test is actually correct in its assumption.
Comment #3
jhedstromThis gets the tests green, but fundamentally changes the nature of the last assertion (previously looking for the top-level parent, now it looks for the immediate parent).
Comment #4
grendzy commentedYes, I agree that MenuLinkInterface::getParent is intended to return the immediate parent. RTBC!
Comment #5
xjmNice find! And thank you for documenting when the regression was introduced; definitely helpful for reviewing this. This issue only improves test coverage, so per https://www.drupal.org/core/beta-changes, this can be completed any time during the Drupal 8 beta phase. Committed and pushed to 8.0.x.