Problem/Motivation

In #1916790: Convert translation metadata into regular entity fields we were supposed to remove ContentEntityInterface::initTranslation(), but forgot to.

Proposed resolution

Kill it

Remaining tasks

  • Validate the proposed solution
  • Write a patch
  • Reviews

User interface changes

None

API changes

Removed ContentEntityInterface::initTranslation() but there is no use for it now. In fact no usage in core.

Beta phase evaluation

Reference: https://www.drupal.org/core/beta-changes
Issue category Task because nothing is broken
Issue priority Major because we are unnecessarily exposing the inner workings of the Entity Translation API.
Prioritized changes The main goal of this issue is reducing fragility by removing an unnecessary and confusing method with no test coverage and no usage in core.
Disruption Disruptive for contributed and custom modules using the Entity Translation API the wrong way. Hopefully none.
CommentFileSizeAuthor
#1 et-init_translation_remove-2479815-1.patch1.66 KBplach
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

plach’s picture

plach
he/him
Primary language Italian
Location Venezia
CreditAttribution: plach commented
Assigned: plach » Unassigned
Issue summary: View changes
Status: Active » Needs review
Issue tags: +Novice, +Quick fix
Parent issue: » #1916790: Convert translation metadata into regular entity fields
FileSize
et-init_translation_remove-2479815-1.patch1.66 KB

Here we go

plach’s picture

plach
he/him
Primary language Italian
Location Venezia
CreditAttribution: plach commented
Title: Remove obsolete ContentEntityInterface::initTranslation() » Remove obsolete ContentEntityInterface::initTranslation() method
Issue summary: View changes
dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner for Drupal Association commented
Status: Needs review » Reviewed & tested by the community

Nice!

xjm’s picture

xjm
she/her
Primary language English
CreditAttribution: xjm at Acquia commented
Status: Reviewed & tested by the community » Needs work
Issue tags: +Needs change record

From the summary it sounds like this fits the criteria for reducing fragility through removing unintentional "API", so it makes sense to me to make this change during the beta.

We should probably have a change record though, and check for any CRs that need updates?

plach’s picture

plach
he/him
Primary language Italian
Location Venezia
CreditAttribution: plach commented
Status: Needs work » Reviewed & tested by the community

Not very much to say about this, but I guess having a minimal CR makes sense:

https://www.drupal.org/node/2480357

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick at Acquia commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed to 8.0.x. Thanks!

  • webchick committed 08b9766 on 8.0.x 
    Issue #2479815 by plach: Remove obsolete ContentEntityInterface::...
plach’s picture

plach
he/him
Primary language Italian
Location Venezia
CreditAttribution: plach commented

Thanks, published CR.

Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy at Acquia commented
Issue tags: -sprint

Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.