Tablefield 2.4 was recently released:

https://www.drupal.org/node/2474989

Looks like it's just bug fixes.

This is used by the Table widget in panopoly_widgets. We have some automated tests, but manual testing would help too!

TODO

  • This update breaks live preview. I think it's all the marshalling the data to/from the internal format. If so, we'll probably need to patch tablefield.
CommentFileSizeAuthor
#10 panopoly_magic-update_tablefield_to-2479569-10.patch703 bytesmglaman
#4 panopoly_test-tablefield24-2479569-3.patch3.4 KBdsnopek
#4 panopoly_widgets-tablefield24-2479569-3.patch888 bytesdsnopek

Comments

  • dsnopek committed 4f92a91 on 7.x-1.x 
    Update Panopoly Widgets for Issue #2479569: Update tablefield to version...
dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
commented
Status: Active » Fixed

Required a change to the Feature for a change in the formatter name, but otherwise works for me! Commiting and we'll see what Travis-CI has to say about it:

https://travis-ci.org/panopoly/panopoly/builds/60842564

  • dsnopek committed a84367f on 7.x-1.x 
    Revert "Update Panopoly Widgets for Issue #2479569: Update tablefield to...
dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
commented
Status: Fixed » Needs review
StatusFileSize
new panopoly_widgets-tablefield24-2479569-3.patch888 bytes
new panopoly_test-tablefield24-2479569-3.patch3.4 KB

Travis-CI doesn't like it! Part of the problem is that the id's on all the form inputs has changed. But live preview also breaks. :-/

So, I'm going to revert it and post some incomplete patches here.

dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
commented
Issue summary: View changes

Added some info to the issue summary about the live preview problem.

dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
commented
Issue tags: +sprint
dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
commented
Status: Needs review » Needs work
dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
commented
Parent issue: » #2530998: [meta] Get Panopoly 1.x into maintenance mode (so we can focus on Drupal 8)
mglaman’s picture

mglaman
Primary language English
Location WI, USA
commented
Assigned: Unassigned » mglaman

Investigating

mglaman’s picture

mglaman
Primary language English
Location WI, USA
commented
Assigned: mglaman » Unassigned
Status: Needs work » Needs review
StatusFileSize
new panopoly_magic-update_tablefield_to-2479569-10.patch703 bytes

We need to invoke presave! Everything seems to be working then, and now we're implementing the field API hooks properly, like invoke multiple load.

  • dsnopek committed bd93fbd on 7.x-1.x 
    Update Panopoly Widgets, Magic and Test for Issue #2479569 by dsnopek,...
dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
commented
Status: Needs review » Fixed

Tests passed! Committed. :-)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.