Hi there,
Because of logic in hook_menu getting lack of performance at admin/config page. Items are not being cached. Tested both on local env and Pantheon.
The same code for the 6 and 7 versions need to be divided:
// Admin page.
if (defined('VERSION') && substr(VERSION, 0, 1) >= 7) {
$config_url = 'admin/config/development/httprl';
}
else {
$config_url = 'admin/settings/httprl';
}
$items[$config_url] = array(
'title' => 'HTTPRL',
'description' => 'Configure HTTPRL settings.',
'access arguments' => array('administer site configuration'),
'page callback' => 'drupal_get_form',
'page arguments' => array('httprl_admin_settings_form'),
'type' => MENU_NORMAL_ITEM,
'file' => 'httprl.admin.inc',
);
Drupal 7, just:
// Admin page.
$items['admin/config/development/httprl'] = array(
Drupal 6, just:
// Admin page.
$items['admin/settings/httprl'] = array(
Comments
Comment #1
sawabe commentedPatch
Comment #2
sawabe commentedComment #3
sawabe commentedComment #4
sawabe commentedComment #5
mikeytown2 commentedI don't understand why this would even matter. hook_menu only gets called by https://api.drupal.org/api/drupal/includes!menu.inc/function/menu_router... and https://api.drupal.org/api/drupal/modules!system!system.module/function/...
Comment #6
sawabe commentedSorry for taking so long to reply. I think we can close this. Cannot reproduce the issue on other instances.
@mikeytown2 is right about caching, but proposed patch solved my issue.
Thanks.
Comment #7
mikeytown2 commented