Fix case of SuperNovaGenerator in HelpEmptyPageTest

Not to be pedantic, but supernova is one word, not two. So we should fix this the opposite way; by renaming the class to SupernovaGenerator.

#2: :D

As per #2 :0

Can you reroll the patch with git diff -M10%? That'll prevent this from showing up as a deletion + addition in the patch, but as a move instead.

Much easier to review now, thanks! :)

The reason the test fails is it can't recognize the changed file name. I ran this command and hope it makes it through the test: git mv --force SuperNovaGenerator.php SupernovaGenerator.php

If this doesn't work, I'll try again without the git diff -M10%

I believe this might have been corrected via another issue, as I went to fix this from 8.0.x, but it seemed to have already been committed.

Can someone verify this and then close this if it is no longer needed?

Thanks!

I am removing the Novice Tag from this Issue because all tasks have been completed.

Thanks for re-adding the "Novice" tag :) I've been following this issue for the last several days and I tested the latest patch. It works and I did not notice any issues. The only thing that bothers me is that that documentation needs to be updated as well, so that the examples will include the new "SupernovaGenerator":

https://api.drupal.org/api/drupal/core!modules!help!tests!modules!help_t...

Thus, I added the "Needs Update Documentation" tag and changed the status to "Reviewed & Tested by the Community".

Ah, good catch! :) No worries; that page will automatically be updated once the code is committed to core.

I think it will help the final review by a core committer if the issue summary gives more details than "Fix" under the "Proposed resolution" header. Especially since the proposed fix changed after the issue was originally posted.

I am leaving the Novice tag on this issue for the task of updating the issue summary.

+++ b/core/modules/help/src/Tests/HelpEmptyPageTest.php
similarity index 92%
rename from core/modules/help/tests/modules/help_test/src/SuperNovaGenerator.php

rename from core/modules/help/tests/modules/help_test/src/SuperNovaGenerator.php
rename to core/modules/help/tests/modules/help_test/src/SupernovaGenerator.php

rename to core/modules/help/tests/modules/help_test/src/SupernovaGenerator.php
index 2103efc..3b6adec 100644

+1 for that naming, a Supernova is a thing for itself

Definitely one word, agreed. :)

Since I have a stupid case-insensitive filesystem, I had to commit this patch like so:

1. Download the patch.
2. Manually remove the rename lines to create the attached patch.
3. Apply the modified patch with git apply --index
4. ...I was expecting to have to do as @andile2012 did at this point but it seems to have worked just like that so I committed it. :P I guess we'll know if HEAD fails that I also failed... :)

This issue only changes test code, so per https://www.drupal.org/core/beta-changes, this can be completed any time during the Drupal 8 beta phase. Committed and pushed to 8.0.x. Thanks!