Performance issue

Ported patch pathauto-persists-936222-281_0 from the linked issue for the pathauto_entity_load and pathauto_entity_state_load_multiple functions.

Corrected function names & tweaked Drupal static usage.

I missed the drupal_static_reset out!

No news ?

1. +++ b/pathauto_persist.module
   @@ -4,9 +4,29 @@
   +    $path_auto_entity_types = db_query("SELECT entity_type FROM {pathauto_persist} GROUP BY entity_type")->fetchAllKeyed(0, 0);
   

   Shouldn't this just be SELECT DISTINCT entity_type instead of using a GROUP BY?

2. +++ b/pathauto_persist.module
   @@ -4,9 +4,29 @@
   +      if (!isset($entities[$id]->path) || !is_array($entities[$id]->path)) {
   +        $entities[$id]->path = array();
   +      }
   

   This is handled by https://www.drupal.org/node/2107365 and not related to performance.

3. +++ b/pathauto_persist.module
   @@ -63,7 +83,35 @@ function pathauto_persist_entity_state_load($entity_type, $entity_id) {
   +  if (!$table_exists) {
   +    if (!defined('MAINTENANCE_MODE')) {
   +      $message = t('The <code>pathauto_state

   table does not exist, so a default value was provided. Please make sure to run update.php');
   + drupal_set_message($message, 'warning');
   + watchdog('pathauto', $message, array(), WATCHDOG_WARNING);
   + }
   + $result = array();
   + foreach ($entity_ids as $id) {
   + $result[$id] = FALSE;
   + }
   +
   + return $result;
   + }
   

   This is not relevant for pathauto_persist.

+++ b/pathauto_persist.module
@@ -63,7 +83,35 @@ function pathauto_persist_entity_state_load($entity_type, $entity_id) {
+  // Filter out entity_ids that are not integers.
+  $entity_ids = array_filter($entity_ids, 'is_numeric');
+  // If everything was filtered out, return an empty array.
+  if (empty($entity_ids)) {
+    return array();
+  }

This should be left out too.

Updated with all the un-relevant sections removed.

Try that again, I had staged everything but didn't use git diff --cached.

Turns out drupal_static_reset() doesn't like using a query result as the default parameter. Need to set separately.

Committed #14 to 7.x-1.x.