Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
This issue is part of #2454513: [meta] Make Drupal 8 work with SQLite.
Drupal\system\Tests\Database\FetchTest
is currently failing on SQLite because Drupal\Core\Database\StatementPrefetch
does not take $allowRowCount
into consideration.
Comment | File | Size | Author |
---|---|---|---|
#1 | 2475177.patch | 801 bytes | amateescu |
Comments
Comment #1
amateescu CreditAttribution: amateescu for Drupal Association commentedTest run before:
Test run after:
Comment #2
amateescu CreditAttribution: amateescu for Drupal Association commentedThis patch also fixes
Drupal\system\Tests\Database\SelectComplexTest
which has the same assertion at the bottom of the test class: http://cgit.drupalcode.org/drupal/tree/core/modules/system/src/Tests/Dat...Comment #3
m4oliveiConfirmed that the patch applies cleanly on the latest D8. It also fixes the failing test and makes sense from a read through. I'd suggest leaving the comment that reads
Implementations of StatementInterface.
, and leaving out the{@inheritdoc}
docblock. This whole file could use some documentation love and it probably makes more sense to do it as a whole, rather than piecemeal. I could be wrong, I'm new here.Comment #4
amateescu CreditAttribution: amateescu for Drupal Association commentedI think fixing the doxygen block of the function we're dealing with is in scope of this patch, and, yes, we need a different issue to fix the rest of the file.
Comment #5
dawehnerYeah I think its fine, its just a small change and the diff context is still the same / did not got extended.
Let's create a follow up for that: #2478355: Fix documentation style in core/lib/Drupal/Core/Database/StatementPrefetch.php
Comment #7
xjm@m4olivei, you are actually correct by the way. :) And If the patch were bigger or the docblock updated were in a different hunk, I'd indeed push back on the coding standards update. But in this case I'm just going to commit it because in an 800-byte patch and the same hunk I'd prefer to just get this in, especially as it's a part of a critical.
I can't decide whether it's major as a test failure on a secondary environment or critical as a required part of the critical, but landing on major at least, and as a simple bug fix, it is prioritized during the beta. Committed and pushed to 8.0.x. Thanks @amateescu, @m4olivei, and @dawehner!