Problem/Motivation

The Custom Menu Link module help misses a link to the online documentation on drupal.org and a link to the menu page.

Proposed resolution

Add the two links. The link to the Menu admin page needs to be set so that it is only active if the Menu UI module is enabled. See #2473105: Update hook_help texts that link to modules that can be uninstalled

Remaining tasks

User interface changes

API changes

CommentFileSizeAuthor
#10 Custom Menu Links hook help.png193.8 KBdarol100
#9 interdiff-5-9.txt2.24 KBfmb
#9 hook_help_custom_menu_link-2473813-9.patch1.91 KBfmb
#5 interdiff-5.txt2.09 KBjoshi.rohit100
#5 hook_help_custom_menu_link-2473813-5.patch1.87 KBjoshi.rohit100
#1 hook_help_custom_menu_link-2473813-1.patch1.87 KBfmb

Comments

fmb’s picture

fmb commented
Status: Active » Needs review
StatusFileSize
new hook_help_custom_menu_link-2473813-1.patch1.87 KB

Here is a patch.

ifrik’s picture

ifrik
she/her
commented
Issue tags: +drupaldevdays
jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented
Status: Needs review » Reviewed & tested by the community

Looks OK to me, thanks!

xjm’s picture

xjm
she/her
Primary language English
commented
Status: Reviewed & tested by the community » Needs work

Thanks @FMB! Two small things that should be easy to fix:

  1. See the <a href="!menu-help">Menu UI module help page</a>, and the <a href="!drupal-org-help">documentation page on drupal.org</a> for more information.

    There's an extra comma in there that should be removed.

  2. Drupal.org should be capitalized when it is used in text as the name of the site.

As this changes UI text only, it is unfrozen and so can go in during the beta. Thanks!

joshi.rohit100’s picture

joshi.rohit100
he/him
Primary language Hindi
Location Delhi, India
commented
Status: Needs work » Needs review
StatusFileSize
new hook_help_custom_menu_link-2473813-5.patch1.87 KB
new interdiff-5.txt2.09 KB

Status: Needs review » Needs work

The last submitted patch, 5: hook_help_custom_menu_link-2473813-5.patch, failed testing.

lauriii queued 5: hook_help_custom_menu_link-2473813-5.patch for re-testing.

ifrik’s picture

ifrik
she/her
commented

Sorry for one more change

The usual wording would be "For more information, see the online documentation for the Custom MenuLinks module".

That way it's consistent with the help texts, and it avoids the mentioning of "Drupal" so that it works well in other distributions as well.

fmb’s picture

fmb commented
Status: Needs work » Needs review
StatusFileSize
new hook_help_custom_menu_link-2473813-9.patch1.91 KB
new interdiff-5-9.txt2.24 KB
darol100’s picture

darol100 commented
Issue summary: View changes
StatusFileSize
new Custom Menu Links hook help.png193.8 KB

This patch seem to be working fine.

Here is an image of the results.

darol100’s picture

darol100 commented
Status: Needs review » Reviewed & tested by the community
webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Fixed

Great stuff. Committed and pushed to 8.0.x. Thanks!

  • webchick committed 4acf0c9 on 8.0.x 
    Issue #2473813 by FMB, joshi.rohit100, darol100, ifrik, jhodgdon, xjm:...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.