Problem/Motivation

This issue is a follow-up to this critical: #2350837: Convert most usages of EntityInterface::getSystemPath() to use routes

Fix @todo in BasicAuthTest:
// @todo Change ->drupalGet() calls to just pass $url when
//   https://www.drupal.org/node/2350837 gets committed

Proposed resolution

Simply change next line from
$this->drupalGet($url->setAbsolute()->toString());
to
$this->drupalGet($url);

Remaining tasks

The PRCs ! :
- patch it
- review it
- commit it

User interface changes

None

API changes

None

Beta phase evaluation

Reference: https://www.drupal.org/core/beta-changes
Issue category Task because it follows-up on another issue.
Issue priority Normal because this issue is a follow-through on something that isn't broken.
Unfrozen changes Unfrozen because it only improves automated tests.
CommentFileSizeAuthor
#1 clean-up-todo--2473687-1.patch980 bytesdom.

Comments

dom.’s picture

dom. commented
Status: Active » Needs review
StatusFileSize
new clean-up-todo--2473687-1.patch980 bytes

Just add the easy fix as per description !

mile23’s picture

mile23
Primary language English
Location Seattle, WA
commented
Issue summary: View changes
Related issues: +#2350837: Convert most usages of EntityInterface::getSystemPath() to use routes

Mile23 queued 1: clean-up-todo--2473687-1.patch for re-testing.

mile23’s picture

mile23
Primary language English
Location Seattle, WA
commented

Retesting to discover if this patch is still good. It applies, but let's find out if it's meaningful.

It passed before.

mile23’s picture

mile23
Primary language English
Location Seattle, WA
commented
Status: Needs review » Reviewed & tested by the community

Still passes, so RTBC.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Fixed

Nice catch. :)

Committed and pushed to 8.0.x. Thanks!

  • webchick committed 873c5aa on 8.0.x 
    Issue #2473687 by Dom.: Fix @todo in BasicAuthTest

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.