@alexpott noticed that all the Drupal\system\Tests\Installer\* tests are failing on the temp SQLite testbot, now that it's back.

Let's fix them :)

Drupal\system\Tests\Installer\DistributionProfileTest          9 passes  11 fails   1 exceptions             
Drupal\system\Tests\Installer\InstallerEmptySettingsTest       8 passes  11 fails   2 exceptions             
Drupal\system\Tests\Installer\InstallerExistingInstallationT   8 passes  11 fails   1 exceptions             
Drupal\system\Tests\Installer\InstallerLanguageDirectionTest  10 passes  11 fails   1 exceptions             
Drupal\system\Tests\Installer\InstallerLanguagePageTest      200 passes  11 fails   1 exceptions             
Drupal\system\Tests\Installer\InstallerTest                   10 passes  11 fails   1 exceptions             
Drupal\system\Tests\Installer\InstallerTranslationMultipleLa   8 passes  11 fails   1 exceptions             
Drupal\system\Tests\Installer\InstallerTranslationMultipleLa   8 passes  11 fails   1 exceptions             
Drupal\system\Tests\Installer\InstallerTranslationMultipleLa   8 passes  11 fails   1 exceptions             
Drupal\system\Tests\Installer\SingleVisibleProfileTest         6 passes  11 fails   1 exceptions             
Drupal\system\Tests\Installer\InstallerTranslationTest        10 passes  11 fails   1 exceptions             
Drupal\system\Tests\Installer\StandardInstallerTest           10 passes  11 fails   1 exceptions
CommentFileSizeAuthor
#1 2473075.patch862 bytesamateescu

Comments

amateescu’s picture

amateescu commented
Assigned: Unassigned » alexpott
Status: Active » Needs review
StatusFileSize
new 2473075.patch862 bytes

I'm still not able to reproduce this locally for some reason (even after @alexpott gave me his exact run-test command), so I'm shooting in the dark here but I think this patch should fix it.

Assigning to Alex for a manual test run :)

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Needs review » Reviewed & tested by the community

Ran tests locally and they are green - nice.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented 
 8.0.x  alex: ~/dev/sites/drupal8alt.dev > d8sqlitetestnodb Installer

Drupal test run
---------------

Tests to be run:
  - Drupal\system\Tests\Installer\DistributionProfileTest
  - Drupal\system\Tests\Installer\InstallerEmptySettingsTest
  - Drupal\system\Tests\Installer\InstallerExistingDatabaseSettingsTest
  - Drupal\system\Tests\Installer\InstallerExistingInstallationTest
  - Drupal\system\Tests\Installer\InstallerExistingSettingsNoProfileTest
  - Drupal\system\Tests\Installer\InstallerExistingSettingsTest
  - Drupal\system\Tests\Installer\InstallerLanguageDirectionTest
  - Drupal\system\Tests\Installer\InstallerLanguagePageTest
  - Drupal\system\Tests\Installer\InstallerLanguageTest
  - Drupal\system\Tests\Installer\InstallerTest
  - Drupal\system\Tests\Installer\InstallerTranslationMultipleLanguageForeignTest
  - Drupal\system\Tests\Installer\InstallerTranslationMultipleLanguageKeepEnglishTest
  - Drupal\system\Tests\Installer\InstallerTranslationMultipleLanguageTest
  - Drupal\system\Tests\Installer\InstallerTranslationTest
  - Drupal\system\Tests\Installer\InstallerTranslationVersionUnitTest
  - Drupal\system\Tests\Installer\SingleVisibleProfileTest
  - Drupal\system\Tests\Installer\SiteNameTest
  - Drupal\system\Tests\Installer\StandardInstallerTest

Test run started:
  Tuesday, April 21, 2015 - 15:12

Test summary
------------

Drupal\system\Tests\Installer\DistributionProfileTest         18 passes
Drupal\system\Tests\Installer\InstallerEmptySettingsTest      16 passes
Drupal\system\Tests\Installer\InstallerExistingDatabaseSetti  16 passes
Drupal\system\Tests\Installer\InstallerExistingInstallationT  26 passes
Drupal\system\Tests\Installer\InstallerExistingSettingsNoPro  15 passes
Drupal\system\Tests\Installer\InstallerExistingSettingsTest   15 passes
Drupal\system\Tests\Installer\InstallerLanguageDirectionTest  28 passes
Drupal\system\Tests\Installer\InstallerLanguagePageTest      208 passes
Drupal\system\Tests\Installer\InstallerLanguageTest            8 passes
Drupal\system\Tests\Installer\InstallerTest                   20 passes
Drupal\system\Tests\Installer\InstallerTranslationMultipleLa  65 passes
Drupal\system\Tests\Installer\InstallerTranslationMultipleLa  54 passes
Drupal\system\Tests\Installer\InstallerTranslationMultipleLa  56 passes
Drupal\system\Tests\Installer\InstallerTranslationTest        76 passes
Drupal\system\Tests\Installer\InstallerTranslationVersionUni  20 passes
Drupal\system\Tests\Installer\SingleVisibleProfileTest        20 passes
Drupal\system\Tests\Installer\SiteNameTest                     3 passes
Drupal\system\Tests\Installer\StandardInstallerTest           49 passes

Test run duration: 4 min 55 sec

Evidence.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 1: 2473075.patch, failed testing.

amateescu’s picture

amateescu commented

The test fails looks very random and unrelated:

Drupal\action\Tests\ActionUninstallTest
Drupal\field_ui\Tests\ManageDisplayTest
Drupal\node\Tests\NodeTranslationUITest
Drupal\responsive_image\Tests\ResponsiveImageFieldDisplayTest
Drupal\system\Tests\Theme\ThemeTest
Drupal\user\Tests\UserCancelTest

Status: Needs work » Needs review

amateescu queued 1: 2473075.patch for re-testing.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Needs review » Reviewed & tested by the community

#4 fails on Maximum execution time of 300 seconds exceeded PHP Fatal error ApcClassLoader.php 114
I think this is testbot file system weirdness.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Assigned: alexpott » Unassigned
xjm’s picture

xjm
she/her
Primary language English
commented
Category: Task » Bug report
Priority: Normal » Major
Status: Reviewed & tested by the community » Fixed
Issue tags: +sqlite

As a test failure in a secondary environment, this issue is a major bug per https://www.drupal.org/core/issue-priority#major-bug, and so the fix is prioritized during the Drupal 8 beta.

The comment had a goofy wording, so I made the following small fix on commit:

--- a/core/modules/simpletest/src/WebTestBase.php
+++ b/core/modules/simpletest/src/WebTestBase.php
@@ -981,7 +981,7 @@ protected function installParameters() {
     unset($connection_info['default']['namespace']);
     unset($connection_info['default']['pdo']);
     unset($connection_info['default']['init_commands']);
-    // Remove db connection info not that are not needed by SQLite.
+    // Remove database connection info that is not used by SQLite.
     if ($driver == 'sqlite') {
       unset($connection_info['default']['username']);
       unset($connection_info['default']['password']);

Committed and pushed to 8.0.x, thanks!

  • xjm committed e9c8dcf on 
    Issue #2473075 by amateescu, alexpott: SQLite: Fix system\Tests\...
amateescu’s picture

amateescu commented

Ugh, that comment was more than goofy, I was juggling too many patches at the same time :/ Thanks for the fast review and commit!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.