Entity reference, views filter reference method is broken.

Thanks @bircher, good find and very clear steps to reproduce.

Agreed that this is major per: https://www.drupal.org/core/issue-priority#major-bugs It's a significant bug (and a regression), but ER and Views are still usable overall, and we would not block release on it.

This fixes that. Working on test coverage.

Added test.

Ok, I overlooked that the view should have actually been there and just fixed the fatal error.
In this one the eligible views are found correctly, I also added some more tests to demonstrate this.

https://www.drupal.org/node/2454481 is an *older* bug report that this fully fixes (since this has a test case and identical fixes) as well as fixing further problems.

Thank you for finding the old issue, I totally forgot about that. Marked that one as duplicate of this issue.

+++ b/core/modules/views/src/Plugin/EntityReferenceSelection/ViewsSelection.php
@@ -110,7 +110,7 @@ public function buildConfigurationForm(array $form, FormStateInterface $form_sta
       list($view, $display_id) = $data;
-      if ($view->storage->get('base_table') == $entity_type->getBaseTable()) {
+      if ($view->storage->get('base_table') == $entity_type->getDataTable()) {

Its not that always. I'd vote for if (in_array($view->storage->get('base_table'), [$entity_type->getBaseTable(), $entity_type->getDataTable()], given that there might be entity types without a data table

NW for #13

Fixed feedback in #13

Thank you @geertvd for updating the patch.

+++ b/core/modules/views/src/Plugin/EntityReferenceSelection/ViewsSelection.php
@@ -110,7 +110,7 @@ public function buildConfigurationForm(array $form, FormStateInterface $form_sta
+      if (in_array($view->storage->get('base_table'), [$entity_type->getBaseTable(), $entity_type->getDataTable()])) {

@dawehner do you think we should add tests for this change because this seems to me a very important piece of the puzzle.

@dawehner do you think we should add tests for this change because this seems to me a very important piece of the puzzle.

Yeah we absolutely should! So once for an entity type with just a base table and one with also a data table.

Extended the test a bit, we are also testing this with entity_test now so we should have test coverage in case we just use base table also.

Thanks, test coverage looks good now I think.

People who are interested in this might also be interested in two other ViewsSelection bugs:

#2482625: Views entity reference selection with autocomplete widget broken and #2482705: ViewsSelection::validateAutocompleteInput is not implemented

Committed f7c357e and pushed to 8.0.x. Thanks!

Thanks for adding the beta evaluation to the issue summary.