Noticed this while working on #2468045: When deleting a content type field, users do not realize the related View also is deleted

In \Drupal\views\Plugin\views\argument_validator\Entity there's an unused variable in calculateDependencies()
Probably mistakenly added in #2368767: Implement calculateDependencies() in ArgumentPluginBase to get dependencies from validator and default plugins

CommentFileSizeAuthor
#1 2472413-1.patch875 bytesgeertvd

Comments

geertvd’s picture

geertvd commented
Status: Active » Needs review
StatusFileSize
new 2472413-1.patch875 bytes
geertvd’s picture

geertvd commented
Issue summary: View changes
xano’s picture

xano
he/they
Primary language English
Location Southampton
commented
Status: Needs review » Reviewed & tested by the community

I manually confirmed this variable is indeed unused. RTBC if the tests pass.

Thanks!

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Fixed

Nice catch. This reduces fragility so is allowed during beta.

Committed and pushed to 8.0.x. Thanks!

  • webchick committed 167b32c on 8.0.x 
    Issue #2472413 by geertvd: Unused variable in \Drupal\views\Plugin\views...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.