Problem/Motivation

User inteface text has been changed since the help text was committted: the Statistics page is now not called "Settings" anymore.

Proposed resolution

Rename the link "statistic settings page" to "Statistics page" in both Uses.

Remaining tasks

User interface changes

API changes

CommentFileSizeAuthor
#1 2472329-statistics-help-text-1.patch2.7 KBjoshi.rohit100

Comments

joshi.rohit100’s picture

joshi.rohit100
he/him
Primary language Hindi
Location Delhi, India
commented
Status: Active » Needs review
StatusFileSize
new 2472329-statistics-help-text-1.patch2.7 KB
Reno Greenleaf’s picture

Reno Greenleaf commented

Tried the patch #1. Link text is "Statistics page" now.

ifrik’s picture

ifrik
she/her
commented
Status: Needs review » Reviewed & tested by the community

Thanks Joshi,

The help text now refers correctly to "Statistics page" in both cases.

  • xjm committed b35223a on 8.0.x 
    Issue #2472329 by joshi.rohit100, ifrik, Reno Greenleaf: Update...
xjm’s picture

xjm
she/her
Primary language English
commented
Status: Reviewed & tested by the community » Fixed
Issue tags: +drupaldevdays

This issue only changes user-facing strings and markup, and the main goal is to improve user-facing documentation, so per https://www.drupal.org/core/beta-changes, this can be completed any time during the Drupal 8 beta phase.

+++ b/core/modules/statistics/statistics.module
@@ -23,9 +23,9 @@ function statistics_help($route_name, RouteMatchInterface $route_match) {
<a href="!statistics-settings">Statistics page</a>

I asked myself whether it makes sense for the URL placeholder to still be !statistics-settings when the label is just "Statistics", but since the route name is still statistics.settings I think it makes sense to keep the placeholder as it refers to that.

Committed and pushed to 8.0.x. Thanks @ifrik, @joshi.rohit100, and @Reno Greenleaf!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.