Problem/Motivation

CacheCollector doesn't detect changing cid after cid has been set. If the cid changes for some reason later on the processing the old cache key will be still used.

Proposed resolution

Re-factor CacheCollector to use a $this->storage[$cid] prefix for all internal storage like HookElementInfo() or implement a kind of SubscriberInterface so that a changing getCid() can be detected and handled.

Remaining tasks

-

User interface changes

-

API changes

-

Comments

Fabianx’s picture

Issue tags: +Twig, +D8 cacheability

Tagging

joelpittet’s picture

Issue tags: -Twig

This doesn't seem to be Twig related. Removing tag. Also, since RC this may not be possible?

Should we move this to 8.1.x?

Fabianx’s picture

Version: 8.0.x-dev » 8.1.x-dev

Yeah, no priority for 8.0.x

catch’s picture

Category: Bug report » Task

Unless there's a functional bug at the moment (in which case we need an issue referenced that this would fix/blocks), this looks like a task to me.

Version: 8.1.x-dev » 8.2.x-dev

Drupal 8.1.0-beta1 was released on March 2, 2016, which means new developments and disruptive changes should now be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.0-beta1 was released on August 3, 2016, which means new developments and disruptive changes should now be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.0-alpha1 will be released the week of January 30, 2017, which means new developments and disruptive changes should now be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.