Problem/Motivation

PageCache::get() returns NULL on a cache miss, but we usually return FALSE everywhere else. Even the docs suggest so already.

Proposed resolution

Return FALSE on a cache miss.

Remaining tasks

Write patch.

User interface changes

none.

API changes

none.

CommentFileSizeAuthor
#4 2471737.patch505 bytesklausi
#1 2471737.patch477 bytesklausi

Comments

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented
Status: Active » Needs review
StatusFileSize
new 2471737.patch477 bytes

klausi opened a new pull request for this issue.

dawehner’s picture

dawehner
Primary language German
commented
Priority: Normal » Minor
Status: Needs review » Reviewed & tested by the community
Issue tags: +Quickfix

I'm not convinced that this is a normal issue though, given that its protected.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 1: 2471737.patch, failed testing.

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented
Status: Needs work » Needs review
StatusFileSize
new 2471737.patch505 bytes

klausi pushed some commits to the pull request.

For an interdiff please see the list of recent commits.

jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented
Priority: Minor » Normal
Status: Needs review » Reviewed & tested by the community

I don't think we need tests here. If this is documented then it's not minor.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed 7e36f27 and pushed to 8.0.x. Thanks!

  • alexpott committed 7e36f27 on 8.0.x 
    Issue #2471737 by klausi: PageCache::get() should return FALSE on a...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.